Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React peerDependency #13

Open
pwlmaciejewski opened this issue Aug 22, 2019 · 1 comment
Open

React peerDependency #13

pwlmaciejewski opened this issue Aug 22, 2019 · 1 comment

Comments

@pwlmaciejewski
Copy link

Current state

In package.json, react is defined as a dependency.

Expected

It should define react as peer dependency.

Workaround

yarn resolutions
@WaldoJeffers
Copy link

It creates a lot of issues: basically, when you add react-native-portal, you automatically add the latest version of React to your bundle, which is probably a different version from the one you are currently using. You then end up with two different versions of React in your bundle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pwlmaciejewski @WaldoJeffers