New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goctl api ts does not generate "?" mark in output ts file #2829

Open

cdz620 opened this issue Jan 30, 2023 · 4 comments

Labels

stale

cdz620 commented Jan 30, 2023

Describe the bug
api file:

type XXXReq {
   Phone string `form:"phone,optional"`
}

shell cmd: goctl api ts ……
generated ts file:

export interface XXXReqParams {
    phone: string
}

Expected behavior
Should generate ts file as follow:

export interface XXXReqParams {
    phone?: string
}

Screenshots
If applicable, add screenshots to help explain your problem.

Environments (please complete the following information):

OS: MacOS
go-zero version: 1.4.4
goctl version: 1.4.4

More description

The text was updated successfully, but these errors were encountered:

Aseisman commented Nov 22, 2023

the same to you , wait for the answer

Author

cdz620 commented Nov 22, 2023

use goctl 1.4.0

Issues-translate-bot commented Nov 22, 2023

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

use goctl 1.4.0

github-actions bot commented Nov 21, 2024

This issue is stale because it has been open for 30 days with no activity.

github-actions bot added the stale label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment