Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --without-suffix for goctl api go #3202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ikilobyte
Copy link

@ikilobyte ikilobyte commented May 4, 2023

生成的文件名每个都带有logichandlermiddleware,这显得非常冗余,实际情况会把不同的业务逻辑放到对应的group内,所以可以去掉这些后缀,因此增加了--without-suffix选项

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #3202 (5ae3096) into master (fe97fab) will increase coverage by 0.01%.
The diff coverage is n/a.

see 1 file with indirect coverage changes

@kevwan
Copy link
Contributor

kevwan commented May 8, 2023

Thanks for your PR! But I'd recommend to keep the suffixes for consistency.

@ikilobyte
Copy link
Author

@kevwan 这个pr能合并吗?

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@kevwan Can this pr be merged?

@fucktx
Copy link

fucktx commented Nov 9, 2023

生成的文件名每个都带有logichandlermiddleware,这显得非常冗余,实际情况会把不同的业务逻辑放到对应的group内,所以可以去掉这些后缀,因此增加了--without-suffix选项

@ikilobyte 文件里面的函数名和结构体那些也会去掉对应的嘛?

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


The generated file names each contain logic, handler, and middleware, which is very redundant. In actual situations, different business logic will be placed in the corresponding group, so these suffixes can be removed. , so the --without-suffix option was added

@ikilobyte Will the corresponding function names and structures in the file also be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants