Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add customer breaker for mongo #3589

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lidaqi001
Copy link

for this #3581

@kevwan kevwan force-pushed the customer-breaker-mongo branch from 0dcd6e2 to a2ea097 Compare October 5, 2023 07:29
@kevwan kevwan self-requested a review October 5, 2023 07:29
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #3589 (a2ea097) into master (3c65bdb) will decrease coverage by 0.19%.
The diff coverage is 6.66%.

❗ Current head a2ea097 differs from pull request most recent head 7e311a4. Consider uploading reports for the commit 7e311a4 to get more accurate results

Additional details and impacted files
Files Coverage Δ
core/stores/mon/model.go 91.72% <14.28%> (-3.96%) ⬇️
core/stores/mon/options.go 55.55% <0.00%> (-44.45%) ⬇️

... and 44 files with indirect coverage changes

@kevwan kevwan force-pushed the customer-breaker-mongo branch from a2ea097 to 6b46f20 Compare October 6, 2023 14:12
@kevwan kevwan added the area/orm Categorizes issue or PR as related to orm. label Oct 23, 2023
@Awadabang
Copy link
Contributor

At most time we need to add some acceptable errors but not to disable the circuit breaker? @lidaqi001

@lidaqi001
Copy link
Author

lidaqi001 commented Nov 23, 2023

At most time we need to add some acceptable errors but not to disable the circuit breaker? @lidaqi001

@Awadabang
I added an option WithoutBreaker
You can customize the broker

@Awadabang
Copy link
Contributor

@lidaqi001
Once WithoutBreaker was used, all models will be affected.
But once WithBreaker was userd, only one model will be affected.
One model's option only affect itself is much better?

@lidaqi001
Copy link
Author

@Awadabang
You can take a look at my changes. Both options are available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/orm Categorizes issue or PR as related to orm.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants