-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
returns type must defined in message.proto #3772
Comments
goctl's interception of external references to proto weakens proto's capabilities, which I don't think should be done. |
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
May I ask why the object in the file cannot be referenced in the return value of go-zero rpc, which can be compiled successfully with the original command, why set this restriction in goctl
Generate code using goctl:
![image](https://private-user-images.githubusercontent.com/19989609/289445448-70cf116b-1fc5-4eb5-bb75-30ad66f0cb80.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NjMzMDksIm5iZiI6MTczODk2MzAwOSwicGF0aCI6Ii8xOTk4OTYwOS8yODk0NDU0NDgtNzBjZjExNmItMWZjNS00ZWI1LWJiNzUtMzBhZDY2ZjBjYjgwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDIxMTY0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMwODgyMzI2OTg4YjJkZmEyMTQ5NDZlYzFmZTYxMWY2NzRkYmY2NDQ3NWMwYzRiYWQ1ZmYyMzRkMDk0OTMxYTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.k3yNtNB7VCk-kQtrMlESgl-tqwD81BYkCHHiMvQMaSY)
Generate code using protoc:
![image](https://private-user-images.githubusercontent.com/19989609/289445568-c27bdec5-f1dd-4638-9bc6-8ff13bb2160e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NjMzMDksIm5iZiI6MTczODk2MzAwOSwicGF0aCI6Ii8xOTk4OTYwOS8yODk0NDU1NjgtYzI3YmRlYzUtZjFkZC00NjM4LTliYzYtOGZmMTNiYjIxNjBlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDIxMTY0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZiZmE3NDAzNWRkNWMxYmI0OTBhMjNjZmU0MmFmY2U4YWY4MTYyZTRlMTE5YjBmZmM1ODZkODA2NDhkMDNkMWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ngXFSNgGtjgoZwIvMQQvyhX8vuQBwFWTuuvj31LmEy4)
The text was updated successfully, but these errors were encountered: