Question about OST_Node when its parents is SUBQUESTION_Node

[ybz79]

Hi,
First thanks for your works.

I find that when generating OST_step after SUBQUESTION_Node，the parameter parent_is_subquestion of do_action_generate_ost_step() is also set to False.

elif self.node_type is Node_Type.SUBQUESTION:

    if not self.disable_a1:
        do_action_generate_ost_step()


    do_action_generate_direct_answers()


    do_action_generate_subquestions()

https://github.com/zhentingqi/rStar/blob/main/run_src/MCTS_for_reasoning.py#L920-L923

I think under this setting, the solution trace is incomplete. If I have missed anything, please let me know. I would greatly appreciate it.

[JiahangXu]

Thank you for your question! This was actually a mistake in our code cleanup. I’ve checked our dev version, and it does have parent_is_subquestion=true here. I’ve now fixed the issue, and you can pull the latest code to see my updates.