Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor DomoMaj #1489

Open
2 tasks
pipiche38 opened this issue Jan 28, 2023 · 2 comments
Open
2 tasks

refactor DomoMaj #1489

pipiche38 opened this issue Jan 28, 2023 · 2 comments
Assignees
@pipiche38
Labels
pinned

Comments

@pipiche38
Copy link
Collaborator

pipiche38 commented Jan 28, 2023 •
edited
Loading

DomoMaj.py requires a big refactoring

  • we should rely only on standard values here, and the mapping must be done in readCluster side or in the device specific.
  • we should refactor the SWITCH_SELECTOR by adding also some context on when the update is applicable. Like Cluster and Attributes
@github-actions
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 29, 2023
@pipiche38 pipiche38 added pinned and removed stale labels Apr 1, 2023
@pipiche38 pipiche38 self-assigned this Dec 16, 2023
@pipiche38
Copy link
Collaborator Author

in progress. a first part done in 7.1.006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pipiche38 pipiche38

Labels
pinned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pipiche38