Skip to content

Commit 69ea0a6

Browse files
committed
Handle reporting and rework manufacturer override
1 parent 8ff2349 commit 69ea0a6

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

zhaquirks/sonoff/swv.py

+6-5
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
"""Sonoff SWV - Zigbee smart water valve."""
22

33
from zigpy.quirks import CustomCluster
4-
from zigpy.quirks.v2 import QuirkBuilder
4+
from zigpy.quirks.v2 import QuirkBuilder, ReportingConfig
55
from zigpy.quirks.v2.homeassistant.binary_sensor import BinarySensorDeviceClass
66
import zigpy.types as t
7+
from zigpy.zcl import foundation
78
from zigpy.zcl.foundation import BaseAttributeDefs, ZCLAttributeDef
89

910

@@ -20,6 +21,7 @@ class CustomSonoffCluster(CustomCluster):
2021
"""Custom Sonoff cluster."""
2122

2223
cluster_id = 0xFC11
24+
manufacturer_id_override: t.uint16_t = foundation.ZCLHeader.NO_MANUFACTURER_ID
2325

2426
class AttributeDefs(BaseAttributeDefs):
2527
"""Attribute definitions."""
@@ -29,10 +31,6 @@ class AttributeDefs(BaseAttributeDefs):
2931
type=ValveState,
3032
)
3133

32-
@property
33-
def _is_manuf_specific(self):
34-
return False
35-
3634

3735
(
3836
QuirkBuilder("SONOFF", "SWV")
@@ -43,6 +41,9 @@ def _is_manuf_specific(self):
4341
device_class=BinarySensorDeviceClass.PROBLEM,
4442
attribute_converter=lambda x: x & ValveState.Water_Leakage,
4543
unique_id_suffix="water_leak_status",
44+
reporting_config=ReportingConfig(
45+
min_interval=30, max_interval=900, reportable_change=1
46+
),
4647
translation_key="water_leak",
4748
fallback_name="Water leak",
4849
)

0 commit comments

Comments
 (0)