From 49d708ce78da6b8426f2c65596db27897f04ecfc Mon Sep 17 00:00:00 2001 From: Pipiche <8291674+pipiche38@users.noreply.github.com> Date: Sun, 8 Dec 2024 18:57:58 +0100 Subject: [PATCH 1/3] print packet when ZDO packet deserialize fails --- zigpy_znp/zigbee/application.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zigpy_znp/zigbee/application.py b/zigpy_znp/zigbee/application.py index 2c22f13..07c691a 100644 --- a/zigpy_znp/zigbee/application.py +++ b/zigpy_znp/zigbee/application.py @@ -474,7 +474,7 @@ async def on_zdo_message(self, msg: c.ZDO.MsgCbIncoming.Callback) -> None: cluster_id=packet.cluster_id, data=packet.data.serialize() ) except Exception: - LOGGER.warning("Failed to deserialize ZDO packet", exc_info=True) + LOGGER.warning( f"Failed to deserialize ZDO packet {packet}", exc_info=True) else: if zdo_hdr.command_id == zdo_t.ZDOCmd.Device_annce: _, ieee, _ = zdo_args From 0a4260505366f140e68fcc26374cb26318741c39 Mon Sep 17 00:00:00 2001 From: Pipiche <8291674+pipiche38@users.noreply.github.com> Date: Sun, 8 Dec 2024 19:04:31 +0100 Subject: [PATCH 2/3] remove space --- zigpy_znp/zigbee/application.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zigpy_znp/zigbee/application.py b/zigpy_znp/zigbee/application.py index 07c691a..0fa50d1 100644 --- a/zigpy_znp/zigbee/application.py +++ b/zigpy_znp/zigbee/application.py @@ -474,7 +474,7 @@ async def on_zdo_message(self, msg: c.ZDO.MsgCbIncoming.Callback) -> None: cluster_id=packet.cluster_id, data=packet.data.serialize() ) except Exception: - LOGGER.warning( f"Failed to deserialize ZDO packet {packet}", exc_info=True) + LOGGER.warning(f"Failed to deserialize ZDO packet {packet}", exc_info=True) else: if zdo_hdr.command_id == zdo_t.ZDOCmd.Device_annce: _, ieee, _ = zdo_args From 9767cbcb89833fd0ac08603dcf369214aa517df3 Mon Sep 17 00:00:00 2001 From: Pipiche <8291674+pipiche38@users.noreply.github.com> Date: Sun, 8 Dec 2024 19:07:55 +0100 Subject: [PATCH 3/3] Moving deserialize ZDO message from warning to debug --- zigpy_znp/zigbee/application.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zigpy_znp/zigbee/application.py b/zigpy_znp/zigbee/application.py index 0fa50d1..e026bb5 100644 --- a/zigpy_znp/zigbee/application.py +++ b/zigpy_znp/zigbee/application.py @@ -474,7 +474,7 @@ async def on_zdo_message(self, msg: c.ZDO.MsgCbIncoming.Callback) -> None: cluster_id=packet.cluster_id, data=packet.data.serialize() ) except Exception: - LOGGER.warning(f"Failed to deserialize ZDO packet {packet}", exc_info=True) + LOGGER.debug(f"Failed to deserialize ZDO packet {packet}", exc_info=True) else: if zdo_hdr.command_id == zdo_t.ZDOCmd.Device_annce: _, ieee, _ = zdo_args