Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react Newest is 16.4.1,but react-tap-event-plugin newest is 16.4.0 #122

Open
tezml opened this issue Jul 5, 2018 · 6 comments
Open

react Newest is 16.4.1,but react-tap-event-plugin newest is 16.4.0 #122

tezml opened this issue Jul 5, 2018 · 6 comments

Comments

@tezml
Copy link

tezml commented Jul 5, 2018

npm report errors and click Invalid.

@ajoshi0
Copy link

ajoshi0 commented Jul 20, 2018

any update on this warning

npm WARN [email protected] requires a peer of react@^16.0.0-0 < 16.4.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of react-dom@^16.0.0-0 < 16.4.0 but none is installed. You must install peer dependencies yourself

@dupski
Copy link

dupski commented Aug 1, 2018

See README. This library is not compatible with react 16.4, it is only compatible with react 16.3 and below

@tezml
Copy link
Author

tezml commented Aug 9, 2018

@dupski i want to say. if compatible to react so bad, this plugs afraid difficult to spread!

@dupski
Copy link

dupski commented Aug 9, 2018

@tezml most browsers have now fixed the issue this library was designed to solve, so it is not needed any more and has been deprecated.

@1003657663
Copy link

@dupski but ios has 300ms delay when i click,and user-scalable="no" can't resolve this problem.
do you have better function to resolve this problem whitout touchTap or fastclick.
because I try react-fastclick and happend ghost click;

@dupski
Copy link

dupski commented Sep 13, 2018

Recent versions of safari don't have this issue AFAIK. Unfortunately I don't know what version of safari they fixed it in.

I had the problem with a Cordova app, but solved it using WKWebView: https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants