From 7c189bdc9804168a7f62e2d16503edbd8c827efd Mon Sep 17 00:00:00 2001 From: Koen Werdler Date: Tue, 8 Oct 2024 12:42:15 +0200 Subject: [PATCH 1/2] Include default gems logger and csv The logger gem will no longer be part of the default gems starting from Ruby 3.5.0, the csv gem will no longer be part of the default gems starting from Ruby 3.4.0. Adding these gems to the gemspec should silence the warnings Ruby 3.3 currently generates on every usage. ``` /Users/koen/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.1.4/lib/active_support/logger_silence.rb:5: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add logger to your Gemfile or gemspec to silence this warning. /Users/koen/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/sequent-7.1.1/lib/sequent.rb:5: warning: csv was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0. You can add csv to your Gemfile or gemspec to silence this warning. ``` --- sequent.gemspec | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sequent.gemspec b/sequent.gemspec index be317eae..f39ae0fc 100644 --- a/sequent.gemspec +++ b/sequent.gemspec @@ -30,8 +30,10 @@ Gem::Specification.new do |s| s.add_dependency 'activemodel', active_star_version s.add_dependency 'activerecord', active_star_version s.add_dependency 'bcrypt', '~> 3.1' + s.add_dependency 'csv', '~> 3.3' s.add_dependency 'i18n' - s.add_dependency 'oj', '~> 3' + s.add_dependency 'logger', '~> 1.6' + s.add_dependency 'oj', '~> 3.3' s.add_dependency 'parallel', '~> 1.20' s.add_dependency 'parser', '>= 2.6.5', '< 3.4' s.add_dependency 'pg', '~> 1.2' From ff39a60d0ad7c5d51bcf7392b3c506ce271a5560 Mon Sep 17 00:00:00 2001 From: Koen Werdler Date: Tue, 8 Oct 2024 15:01:53 +0200 Subject: [PATCH 2/2] Update gem lock files for test suite --- .github/workflows/rspec.yml | 4 ++-- gemfiles/ar_6_0.gemfile.lock | 6 +++++- gemfiles/ar_6_1.gemfile.lock | 6 +++++- gemfiles/ar_7_0.gemfile.lock | 6 +++++- gemfiles/ar_7_1.gemfile.lock | 6 +++++- gemfiles/ar_7_2.gemfile.lock | 5 ++++- 6 files changed, 26 insertions(+), 7 deletions(-) diff --git a/.github/workflows/rspec.yml b/.github/workflows/rspec.yml index 2b88b23c..0f54f5f3 100644 --- a/.github/workflows/rspec.yml +++ b/.github/workflows/rspec.yml @@ -21,10 +21,10 @@ jobs: strategy: matrix: include: - - ruby-version: 3.3 - gemfile: 'ar_7_1' - ruby-version: 3.3 gemfile: 'ar_7_2' + - ruby-version: 3.3 + gemfile: 'ar_7_1' - ruby-version: 3.2 gemfile: 'ar_7_1' - ruby-version: 3.2 diff --git a/gemfiles/ar_6_0.gemfile.lock b/gemfiles/ar_6_0.gemfile.lock index e3c534dd..a9201943 100644 --- a/gemfiles/ar_6_0.gemfile.lock +++ b/gemfiles/ar_6_0.gemfile.lock @@ -5,8 +5,10 @@ PATH activemodel (>= 6.0) activerecord (>= 6.0) bcrypt (~> 3.1) + csv (~> 3.3) i18n - oj (~> 3) + logger (~> 1.6) + oj (~> 3.3) parallel (~> 1.20) parser (>= 2.6.5, < 3.4) pg (~> 1.2) @@ -33,12 +35,14 @@ GEM bigdecimal (3.1.8) coderay (1.1.3) concurrent-ruby (1.2.2) + csv (3.3.0) diff-lcs (1.5.0) docile (1.4.0) i18n (1.14.1) concurrent-ruby (~> 1.0) json (2.6.3) language_server-protocol (3.17.0.3) + logger (1.6.1) method_source (1.0.0) minitest (5.20.0) oj (3.16.6) diff --git a/gemfiles/ar_6_1.gemfile.lock b/gemfiles/ar_6_1.gemfile.lock index 755f4757..f248f1dd 100644 --- a/gemfiles/ar_6_1.gemfile.lock +++ b/gemfiles/ar_6_1.gemfile.lock @@ -5,8 +5,10 @@ PATH activemodel (>= 6.0) activerecord (>= 6.0) bcrypt (~> 3.1) + csv (~> 3.3) i18n - oj (~> 3) + logger (~> 1.6) + oj (~> 3.3) parallel (~> 1.20) parser (>= 2.6.5, < 3.4) pg (~> 1.2) @@ -33,12 +35,14 @@ GEM bigdecimal (3.1.8) coderay (1.1.3) concurrent-ruby (1.2.2) + csv (3.3.0) diff-lcs (1.5.0) docile (1.4.0) i18n (1.14.1) concurrent-ruby (~> 1.0) json (2.6.3) language_server-protocol (3.17.0.3) + logger (1.6.1) method_source (1.0.0) minitest (5.20.0) oj (3.16.6) diff --git a/gemfiles/ar_7_0.gemfile.lock b/gemfiles/ar_7_0.gemfile.lock index c1e7fb60..2851ad8d 100644 --- a/gemfiles/ar_7_0.gemfile.lock +++ b/gemfiles/ar_7_0.gemfile.lock @@ -5,8 +5,10 @@ PATH activemodel (>= 6.0) activerecord (>= 6.0) bcrypt (~> 3.1) + csv (~> 3.3) i18n - oj (~> 3) + logger (~> 1.6) + oj (~> 3.3) parallel (~> 1.20) parser (>= 2.6.5, < 3.4) pg (~> 1.2) @@ -32,12 +34,14 @@ GEM bigdecimal (3.1.8) coderay (1.1.3) concurrent-ruby (1.2.2) + csv (3.3.0) diff-lcs (1.5.0) docile (1.4.0) i18n (1.14.1) concurrent-ruby (~> 1.0) json (2.6.3) language_server-protocol (3.17.0.3) + logger (1.6.1) method_source (1.0.0) minitest (5.20.0) oj (3.16.6) diff --git a/gemfiles/ar_7_1.gemfile.lock b/gemfiles/ar_7_1.gemfile.lock index d173603c..ea397c0b 100644 --- a/gemfiles/ar_7_1.gemfile.lock +++ b/gemfiles/ar_7_1.gemfile.lock @@ -5,8 +5,10 @@ PATH activemodel (>= 6.0) activerecord (>= 6.0) bcrypt (~> 3.1) + csv (~> 3.3) i18n - oj (~> 3) + logger (~> 1.6) + oj (~> 3.3) parallel (~> 1.20) parser (>= 2.6.5, < 3.4) pg (~> 1.2) @@ -40,6 +42,7 @@ GEM coderay (1.1.3) concurrent-ruby (1.2.2) connection_pool (2.4.1) + csv (3.3.0) diff-lcs (1.5.0) docile (1.4.0) drb (2.2.0) @@ -48,6 +51,7 @@ GEM concurrent-ruby (~> 1.0) json (2.6.3) language_server-protocol (3.17.0.3) + logger (1.6.1) method_source (1.0.0) minitest (5.20.0) mutex_m (0.2.0) diff --git a/gemfiles/ar_7_2.gemfile.lock b/gemfiles/ar_7_2.gemfile.lock index 186cf621..7037bb32 100644 --- a/gemfiles/ar_7_2.gemfile.lock +++ b/gemfiles/ar_7_2.gemfile.lock @@ -5,8 +5,10 @@ PATH activemodel (>= 6.0) activerecord (>= 6.0) bcrypt (~> 3.1) + csv (~> 3.3) i18n - oj (~> 3) + logger (~> 1.6) + oj (~> 3.3) parallel (~> 1.20) parser (>= 2.6.5, < 3.4) pg (~> 1.2) @@ -41,6 +43,7 @@ GEM coderay (1.1.3) concurrent-ruby (1.3.4) connection_pool (2.4.1) + csv (3.3.0) diff-lcs (1.5.1) docile (1.4.1) drb (2.2.1)