Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug if NOT self.config.grad_clip #1

Open
zyxue opened this issue Apr 30, 2018 · 1 comment
Open

bug if NOT self.config.grad_clip #1

zyxue opened this issue Apr 30, 2018 · 1 comment

Comments

@zyxue
Copy link

zyxue commented Apr 30, 2018

FYI, https://github.com/zlpure/CS234/blob/master/assignment2/q2_linear.py#L245

would produce error as clipped_grads_and_vars wouldn't be available if not self.clipped_grads_and_vars

@zlpure
Copy link
Owner

zlpure commented May 9, 2019

Thanks! if NOT self.config.grad_clip, clipped_grads_and_vars is not defined. But the performance will be better when using grad clipping. So I omit the self.config.grad_clip flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants