Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assignment 1, vi_and_pi.py, line 106 #2

Open
zhenshan-bing opened this issue Dec 5, 2019 · 1 comment
Open

Assignment 1, vi_and_pi.py, line 106 #2

zhenshan-bing opened this issue Dec 5, 2019 · 1 comment

Comments

@zhenshan-bing
Copy link

Are you missing the reward, which should be "new_value_function[state] += (reward + gamma * probability * value_function[nextstate])" instead of "new_value_function[state] += (gamma * probability * value_function[nextstate])"?
@SonOfAntonv0
Copy link

I think that needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhenshan-bing @SonOfAntonv0