Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

??? #60

Open
SeBL4RD opened this issue Nov 25, 2024 · 5 comments
Open

??? #60

SeBL4RD opened this issue Nov 25, 2024 · 5 comments

Comments

@SeBL4RD
Copy link

SeBL4RD commented Nov 25, 2024

Aren't we on Github here? Are you obfuscating your code?
Is that legal? Ethical?

@zombieyang
Copy link
Owner

zombieyang commented Nov 26, 2024

Appreciate for your following to sd-ppp. I did this for some reason:

  1. You can see another comfy-PS like plugin, which also switched to WebSocket after my first version. Always publish its code with Photoshop plugin minified.
  2. The new canvas helper of forge, publish with obfuscated. ref: stable-diffusion-webui-forge#1232
    After seeing these, compared with my previous open-source work in gaming field. I think the rule is not the same in AI paint tooling field until now.

For the contributors of SD-PPP, I think it is also not a good time to totally open source all the thing, too. While I still keep refactoring large amounts of my code(in 1.3.0, I refactored 80% of my codes. Even in 1.5.0, I refactor 30% of codes). That is why I feel sorry for @tianlang0704 because I abandoned so many of his codes.

What I did is leaving a markdown here: https://github.com/zombieyang/sd-ppp/blob/main/typescripts/develop.md. If someone need the code for learning or bug fixing, I can give the permission.


In the future, I'll still open source it, if:

  1. sd-ppp is famous enough and not easy to be replaced by other project.
  2. I think the code structure is stable enough.

@SeBL4RD
Copy link
Author

SeBL4RD commented Nov 26, 2024

Appreciate for your following to sd-ppp. I did this for some reason:

  1. You can see another comfy-PS like plugin, which also switched to WebSocket after my first version. Always publish its code with Photoshop plugin minified.
  2. The new canvas helper of forge, publish with obfuscated. ref: stable-diffusion-webui-forge#1232
    After seeing these, compared with my previous open-source work in gaming field. I think the rule is not the same in AI paint tooling field until now.

For the contributors of SD-PPP, I think it is also not a good time to totally open source all the thing, too. While I still keep refactoring large amounts of my code(in 1.3.0, I refactored 80% of my codes. Even in 1.5.0, I refactor 30% of codes). That is why I feel sorry for @tianlang0704 because I abandoned so many of his codes.

What I did is leaving a markdown here: https://github.com/zombieyang/sd-ppp/blob/main/typescripts/develop.md. If someone need the code for learning or bug fixing, I can give the permission.

In the future, I'll still open source it, if:

  1. sd-ppp is famous enough and not easy to be replaced by other project.
  2. I think the code structure is stable enough.

Okay, i would learn, could you share me the real code please?

@zombieyang
Copy link
Owner

zombieyang commented Nov 27, 2024

Sure, invatation sent

@tianlang0704
Copy link
Contributor

Appreciate for your following to sd-ppp. I did this for some reason:

  1. You can see another comfy-PS like plugin, which also switched to WebSocket after my first version. Always publish its code with Photoshop plugin minified.
  2. The new canvas helper of forge, publish with obfuscated. ref: stable-diffusion-webui-forge#1232
    After seeing these, compared with my previous open-source work in gaming field. I think the rule is not the same in AI paint tooling field until now.

For the contributors of SD-PPP, I think it is also not a good time to totally open source all the thing, too. While I still keep refactoring large amounts of my code(in 1.3.0, I refactored 80% of my codes. Even in 1.5.0, I refactor 30% of codes). That is why I feel sorry for @tianlang0704 because I abandoned so many of his codes.

What I did is leaving a markdown here: https://github.com/zombieyang/sd-ppp/blob/main/typescripts/develop.md. If someone need the code for learning or bug fixing, I can give the permission.

In the future, I'll still open source it, if:

  1. sd-ppp is famous enough and not easy to be replaced by other project.
  2. I think the code structure is stable enough.

Glad to have helped. I don't mind refactoring at all, please do what's neccessary to make things better.
Just passing by, leaving my little 2 cents.

@SeBL4RD
Copy link
Author

SeBL4RD commented Dec 1, 2024

Sure, invatation sent

Thank you very much.
I really want to understand and be able to help, even though I'm probably nowhere near your level. I'm very busy but I'm very interested. For me, Stable.Art was by far the best in this field, but its developer unfortunately did not continue it.
Your initiative could lead to something, let's hope, SD and Flux are a must-have on Photoshop! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants