Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted games (share link) do not have an error state #261

Open
JorenC opened this issue Aug 23, 2021 · 4 comments
Open

Deleted games (share link) do not have an error state #261

JorenC opened this issue Aug 23, 2021 · 4 comments
Labels
invalid This doesn't seem right

Comments

@JorenC
Copy link
Collaborator

JorenC commented Aug 23, 2021

image

  1. Create a game mastered game
  2. Share the link
  3. Delete the game
  4. Open the link. The game will load a perpetual loading state with white screen.

I suggest we show something like this (@zond if you make the screen I can style it, although I guess you can do this too):
image

Created a new icon for it, added it (should be 80x80):
sunk_ship.zip

@JorenC JorenC added the invalid This doesn't seem right label Aug 23, 2021
@johnpooch
Copy link
Collaborator

Happy to take this one if you like :)

@johnpooch
Copy link
Collaborator

As an aside, we need to include a lot more error handling and tests for error handling. This should be added as we introduce redux and mock service worker. We can use storybook for this as well. Will try get an example of what I'm talking about put together soon

@JorenC
Copy link
Collaborator Author

JorenC commented Aug 23, 2021

Like I said, I'm okay to style it if necessary, so you can speed up with functionality...

@zond
Copy link
Owner

zond commented Aug 24, 2021

@JorenC and @johnpooch I'll leave it in your capable hands then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants