Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better share/Remove "Search game by ID" #282

Open
JorenC opened this issue Sep 5, 2021 · 2 comments
Open

Better share/Remove "Search game by ID" #282

JorenC opened this issue Sep 5, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request UX Not new features but changes to the game or UI that make it a better experience or visually

Comments

@JorenC
Copy link
Collaborator

JorenC commented Sep 5, 2021

In the original Android app, "Search game by ID" was there because there was no game sharing function.

However, now that we have 'share links' it's a bit outdated.
I want to change this:

  1. Create a proper share functionality using the Web Share API: https://www.telerik.com/blogs/using-web-share-api-react
  2. Remove "Search game by ID"
  3. Add diplicity.com link handler in the Android App Manifest (requires some extra proof of ownership tests as described here), allowing the Android App to open these links directly: https://developer.android.com/training/app-links/deep-linking
@JorenC JorenC added enhancement New feature or request UX Not new features but changes to the game or UI that make it a better experience or visually labels Sep 5, 2021
@JorenC JorenC self-assigned this Sep 5, 2021
@JorenC
Copy link
Collaborator Author

JorenC commented Sep 12, 2021

Better share implemented for 'invite' in the game menu, 'share' and 'invite' in the overflow menu.
TBD: Game Master mode.

@JorenC
Copy link
Collaborator Author

JorenC commented Sep 21, 2021

Web API created. However, we still need to have a way to open links in the Android app - e.g. handling the links in the manifest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UX Not new features but changes to the game or UI that make it a better experience or visually
Projects
None yet
Development

No branches or pull requests

1 participant