Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GM Mode] Can't invite players #290

Open
JorenC opened this issue Sep 18, 2021 · 4 comments
Open

[GM Mode] Can't invite players #290

JorenC opened this issue Sep 18, 2021 · 4 comments

Comments

@JorenC
Copy link
Collaborator

JorenC commented Sep 18, 2021

image

There is no invite option, even though there are open players

image

I suspect:

  • members.Replaceable = true (missing player), but it's not inviting new players because the game thinks it's full (e.g. it's playing).

Also, the game is -39 minutes, because it can't move forward with a missing player...?

@JorenC
Copy link
Collaborator Author

JorenC commented Sep 18, 2021

Seems the missing player is preventing the game to move forward. TODO: make a better 'paused while waiting for player' UI

@zond
Copy link
Owner

zond commented Sep 20, 2021

Are you able to join the game as another player at this point?

@JorenC
Copy link
Collaborator Author

JorenC commented Sep 20, 2021

I created the invite option, the logic was that if the game has started the invite button is hidden. It's fixed in my better-gm-mode branch. I also made a different UI that now shows not the next phase deadline but a player sign in red (e.g. 5/7).

@zond you wanted to check whether this was actually planned to prevent the phase to move forward or not, right?

@zond
Copy link
Owner

zond commented Sep 21, 2021

I don't understand - this issue isn't about the phase moving forward or not, but about whether a user can join or not?

If the latter - is that fixed in your better-gm-mode branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants