Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsiveness #292

Open
JorenC opened this issue Sep 23, 2021 · 4 comments
Open

Responsiveness #292

JorenC opened this issue Sep 23, 2021 · 4 comments
Labels
enhancement New feature or request invalid This doesn't seem right UX Not new features but changes to the game or UI that make it a better experience or visually

Comments

@JorenC
Copy link
Collaborator

JorenC commented Sep 23, 2021

Feedback from the people over at "Legendary Tactics" is valid:

  • The app is not responsive. @johnpooch will React Native and proper routing fix this? @zond would a move to Firebase fix this?

We gave the Cold War variant a try and I have to say that the experience was not good. We're playing on our PC's, and when we launched the game, it wouldn't respond to any amount of clicking around. When we choose a unit, the options for commands doesn't come up. We had to switch to phone mode (inspect) to be able to input orders. I was only able to view the map on a tiny window, which made it difficult to see the entirety of the map. As I was dragging the map around to see other parts, it was calling up the orders menu unintentionally. I didn't know what unit I'd accidentally clicked on, and so I ended up canceling orders that I'd already inputted. Have we done something wrong that we can't play on a PC from a web browser in normal viewing mode? If you can work out some of these issues, I think the barrier to entry on Diplicity would encourage more players in, and we could then create a video to support your platform.

@JorenC JorenC added enhancement New feature or request invalid This doesn't seem right UX Not new features but changes to the game or UI that make it a better experience or visually labels Sep 23, 2021
@zond
Copy link
Owner

zond commented Sep 23, 2021

I wonder what circumstances cause what they describe, for me it's never been that bad ever.

Flutter or React Native will probably help. A new backend won't or better routing won't.

@JorenC
Copy link
Collaborator Author

JorenC commented Sep 23, 2021 via email

@johnpooch
Copy link
Collaborator

Hey yeah I think generally improving the react code base will help a lot. It is probably doing an insane amount of rerendering all the time. You can optimize the hell out of it. Just gotta get it cleaned up and well tested before doing proper optimization work. I don't think it has much to do with the wrapper hack that we are using. Mainly just messy React components constantly rerendering.

@zond
Copy link
Owner

zond commented Sep 23, 2021

I don't think they rerender that much - but they do retain a lot memory from being rendered on top of each other. But after you have cleaned up the code we'll see :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right UX Not new features but changes to the game or UI that make it a better experience or visually
Projects
None yet
Development

No branches or pull requests

3 participants