Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open up requests for non logged in requests #145

Open
zond opened this issue May 2, 2020 · 6 comments
Open

Open up requests for non logged in requests #145

zond opened this issue May 2, 2020 · 6 comments

Comments

@zond
Copy link
Owner

zond commented May 2, 2020

Where we don't NEED a login we shouldnt require one

@zond
Copy link
Owner Author

zond commented May 2, 2020

On the other hand - since we are actually disseminating personal information (like people's avatar pictures, and so on), I kind of like it that we require the viewer to also be logged in. It feels a bit less creepy if "only members can see the member list", so to speak.

@tttppp, @JorenC, what do you think?

@zond
Copy link
Owner Author

zond commented May 2, 2020

Also see zond/dipact#121

@tttppp
Copy link
Collaborator

tttppp commented May 5, 2020

I certainly think that viewing the map, orders, etc. should be possible without logging in. Probably even viewing public messages. In fact I think it would make sense to open everything up, given that a user just needs a Google account to see this information currently and so it's basically already publicly available.

@zond
Copy link
Owner Author

zond commented May 5, 2020

It's publically available, but not easy to scrape, which is a big difference.

But yeah, the difference is subtle.

@JorenC
Copy link
Contributor

JorenC commented May 5, 2020

I don't think it's a major issue. If anything, you could hide the player names and avatars if someone is not logged in?

I'm more concerned that someone is logged out (e.g. when the app gets updated) and then uses the link to enter the game, doesn't realise he is logged out and doesn't realise why he needs to log in again - there needs to be a clear "log in" action

@zond
Copy link
Owner Author

zond commented May 5, 2020

Yeah, the UX has to signal pretty clearly what's happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants