Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make phases only resolve during specific times #85

Open
tttppp opened this issue Jun 18, 2017 · 7 comments
Open

Make phases only resolve during specific times #85

tttppp opened this issue Jun 18, 2017 · 7 comments

Comments

@tttppp
Copy link
Collaborator

tttppp commented Jun 18, 2017

This came up in the forum:
https://groups.google.com/forum/m/#!topic/diplicity-talk/X4OMTWD1a1Y

It would be good to allow specifying a start time and the game will only start if there are the right number of players at that time of day.

This sounds relatively involved to implement - it needs changes to diplicity and the clients. It has potential confusion around timezones. It needs the server to run a job at a particular time of day (although this must already be happening with the end-of-phase handling code).

@zond
Copy link
Owner

zond commented Jun 18, 2017

It could also be implemented as a "only ever create new phases between hour a and b", which would allow players in the same tz to play fast games without having to stay awake. And starting the game of course involves creating a phase, so it would also limit the times a game can start.

@zond
Copy link
Owner

zond commented Jun 18, 2017

Staying awake at_night, of course.

@tttppp
Copy link
Collaborator Author

tttppp commented Jun 18, 2017

That's a really great suggestion. There would be some strange edge cases around daylight savings, but it would be much better than not having the option.

I suggest that the phase clock only ticks during the specified hours, but orders and communication can happen outside this time.

@zond
Copy link
Owner

zond commented Jun 18, 2017

Or the phase clock only rings during those hours at least.

@tttppp
Copy link
Collaborator Author

tttppp commented Jun 18, 2017

I think you want ticks, because otherwise potentially someone goes to bed as one phase ends and when they get up the next one immediately ends.

@zond
Copy link
Owner

zond commented Jun 18, 2017

You might be right. All conceptual problems arise when the phase length isn't significantly shorter than the "asleep hours".

@zond
Copy link
Owner

zond commented Jun 18, 2017

Or "awake hours", maybe both?

@zond zond changed the title Games with fixed start time Make phases only resolve during specific times Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants