-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install vim in the zulip
image so that files can be easily edited
#128
Comments
Yeah, we should include this; it won't add much to the container image size and make life a lot easier for manual inspection/debugging. |
@galexrt do you have thoughts on what folks normally do for editors in an image like this? They're pretty small in disk size compared to the rest of the image, so possibly we should just include them, but I'm curious whether folks try to do it under an option or something. |
@timabbott Normally the configs would not be edited inside the container, that is what the I'm against installing any editor, as the config can already be edited from outside the container when |
@galexrt definitely not document. I would much rather have it linked outside and edit it how I like than having to vim inside the container. But compared to not being able to edit without Can you elaborate on the env var here a it? |
@gioragutt If you set |
Amazing. BTW, using docker-compose, what's your suggested method of restarting the server after changing env vars, without losing data? I do it every now and then, always hope mother gets ruined, and yesterday I fucked my server up and lost some data trying to make it work again. |
Just use The container is currently for being started and "on stop" being deleted and recreated. Are you talking about the Zulip server? |
Yes. So the step I'm not doing is the |
This should be added to the docs maybe. "How to restart the server after environment variables changes". Just to be sure, the |
Agreed, I'm reopening this as a documentation issue for covering that. |
@gioragutt |
Hi, consider I'm accessing the zulip container with something like
sudo docker-compose exec zulip /bin/bash
And I want to f.e edit
/etc/zulip/settings.py
, currently the two methods I had were:docker cp
out -> edit the file ->docker cp
in.Not really comfortable, the second one is more reliable, but the best thing would be to easily edit the files with
vim
when you have an open bash in the container.The text was updated successfully, but these errors were encountered: