Skip to content

Commit b4eff26

Browse files
committed
FIXME LINK api/notif [nfc]: Cut comment on FcmMessageChannelRecipient.streamId, relying on server 5+, FL 115+.
See "Feature level 115" from Zulip API changelog: https://zulip.com/api/changelog See also: https://github.com/zulip/zulip/issues/ 18067 Signed-off-by: Zixuan James Li <[email protected]>
1 parent 6855e18 commit b4eff26

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

lib/api/notifications.dart

+1-5
Original file line numberDiff line numberDiff line change
@@ -168,13 +168,9 @@ sealed class FcmMessageRecipient {
168168
@JsonSerializable(fieldRename: FieldRename.snake, createToJson: false)
169169
@_IntConverter()
170170
class FcmMessageChannelRecipient extends FcmMessageRecipient {
171-
// Sending the stream ID in notifications is new in Zulip Server 5.
172-
// But handling the lack of it would add complication, and we don't strictly
173-
// need to -- we intend (#268) to cut pre-server-5 support before beta release.
174-
// TODO(server-5): cut comment
175171
final int streamId;
176172

177-
// Current servers (as of 2023) always send the stream name. But
173+
// Current servers (as of 2024) always send the stream name. But
178174
// future servers might not, once clients get the name from local data.
179175
// So might as well be ready.
180176
@JsonKey(name: 'stream')

0 commit comments

Comments
 (0)