Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Reinstate --depth=1000 in cloning Flutter, once Flutter has a new tag #1204

Closed
chrisbobbe opened this issue Dec 26, 2024 · 0 comments · Fixed by #1304
Closed

ci: Reinstate --depth=1000 in cloning Flutter, once Flutter has a new tag #1204

chrisbobbe opened this issue Dec 26, 2024 · 0 comments · Fixed by #1304
Labels
a-tools Our own development tooling, scripts, and infrastructure

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Dec 26, 2024

Flutter main now has well over a thousand commits since the most recent tag:

diff --git pubspec.yaml pubspec.yaml
index 780c05765..c021e8d1e 100644
--- pubspec.yaml
+++ pubspec.yaml
@@ -14,8 +14,8 @@ environment:
   # We use a recent version of Flutter from its main channel, and
   # the corresponding recent version of the Dart SDK.
   # Feel free to update these regularly; see README.md for instructions.
-  sdk: '>=3.7.0-224.0.dev <4.0.0'
-  flutter: '>=3.28.0-1.0.pre.35'  # 1c1f35711be76d1d2a9f5e3a730747591e64e14a
+  sdk: '>=3.7.0-267.0.dev <4.0.0'
+  flutter: '>=3.28.0-2.0.pre.38575'  # 65ff060283e19423e9538c18c24e44495b70aeff
 
 # To update dependencies, see instructions in README.md.
 dependencies:

These are migrated engine commits from the merge of flutter/engine into the flutter/flutter monorepo.

Anyway, when we do a shallow clone with --depth=1000, CI can't see the most recent tag, which is needed:

      # […] we need the most recent tag
      # so that Flutter knows its version and sees the constraint in our
      # pubspec is satisfied. […]

So we'll be temporarily removing the --depth=1000, to do a full clone instead of a shallow clone. See discussion: #1184 (comment)

That change will slow down CI, so this issue is to reinstate the --depth=1000 once Flutter makes a new tag.

@chrisbobbe chrisbobbe added the a-tools Our own development tooling, scripts, and infrastructure label Dec 26, 2024
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Dec 26, 2024
@gnprice gnprice added this to the M5: Launch milestone Dec 27, 2024
gnprice pushed a commit to chrisbobbe/zulip-flutter that referenced this issue Dec 27, 2024
Gaurav-Kushwaha-1225 pushed a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this issue Jan 8, 2025
Gaurav-Kushwaha-1225 pushed a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this issue Jan 8, 2025
@gnprice gnprice modified the milestones: M5: Launch, M5-a: Server 10 Jan 14, 2025
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jan 24, 2025
…ack later"

This reverts commit 2b99578.

Fixes: zulip#1204

Signed-off-by: Zixuan James Li <[email protected]>
rishichirchi pushed a commit to rishichirchi/zulip-flutter that referenced this issue Feb 7, 2025
…ack later"

This reverts commit 2b99578.

Fixes: zulip#1204

Signed-off-by: Zixuan James Li <[email protected]>
github-actions bot pushed a commit that referenced this issue Feb 12, 2025
…ack later"

This reverts commit 2b99578.

Fixes: #1204

Signed-off-by: Zixuan James Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-tools Our own development tooling, scripts, and infrastructure
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants