Skip to content

Disallow connecting to server 4.x #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnprice opened this issue Apr 2, 2025 · 3 comments
Open

Disallow connecting to server 4.x #1456

gnprice opened this issue Apr 2, 2025 · 3 comments
Labels
a-api Implementing specific parts of the Zulip server API

Comments

@gnprice
Copy link
Member

gnprice commented Apr 2, 2025

This is a reduced, pre-launch version of:

The Zulip Server 5 release went out over 3 years ago, so the 4.x releases are all long out of our announced 18-month compatibility window.

As #268 describes, there are already a few places where we rely on the API of Zulip Server 5 and later. If someone tries using the app on a server older than that, then instead of quietly not working correctly it'd be better to give a clear error. Now that #267 is complete, it'll be straightforward to do that.

(The difference between this issue and #268 is that the latter calls for taking advantage of the new minimum version in order to clear out all the TODO(server-5) items in our codebase. This issue is purely for updating the minimum version set by #267, so as to give the user an error when they're on such an old version.)

References

@gnprice gnprice added the a-api Implementing specific parts of the Zulip server API label Apr 2, 2025
@gnprice gnprice added this to the M5a: Launch blockers milestone Apr 2, 2025
@gnprice
Copy link
Member Author

gnprice commented Apr 2, 2025

I was about to go also file an issue for us to have the legacy app start warning people that older than Server 5 isn't supported and they should (get their admins to) upgrade… but happily we already did that back in 2023 (thanks @chrisbobbe!):

The changelog says that went out to all users in v27.216 and earlier, dated 2023-10-10.

@gnprice
Copy link
Member Author

gnprice commented Apr 2, 2025

This issue isn't yet ripe to carry out (at least not to merge a PR doing it): out of an abundance of caution, I'd like to first get out a beta release containing #267 to disallow servers older than 4.x, and only then merge this change so that it goes out in the next or later beta release.

@chrisbobbe
Copy link
Collaborator

the legacy app

I've just sent zulip/zulip-mobile#5920 to nudge more server admins via the legacy app :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API
Projects
Status: No status
Development

No branches or pull requests

2 participants