Refactored makefile and added new functions move() and fix momary leak

Author: zushar

makefile

@@ -6,8 +6,8 @@ FLAGS = -Wall -g
 run:clean myShell
 	./myShell
 
-leak:
-	valgrind --leak-check=full ./myShell
+leak: clean myShell
+	valgrind --leak-check=full --show-leak-kinds=all ./myShell
 
 myShell: myShell.o myFunction.o
 	$(CC) $(FLAGS) -o myShell myShell.o myFunction.o

myFunction.c

@@ -191,7 +191,6 @@ void delete(char **path)
         printf("-myShell: delete: %s: No such file or directory\n", path[1]);
 }
 
-// Corrected the function return type from 'oid' to 'void'
 void get_dir()
 {
     // Declare a directory stream pointer 'dir' and a directory entry pointer 'entry'
@@ -264,3 +263,32 @@ void mypipe(char **argv1,char ** argv2){
     }
 }
 
+void move(char **arguments){
+    if (arguments[1] == NULL || arguments[2] == NULL){
+        printf("move: missing file operand\n");
+        return;
+    }
+    if (arguments[3] != NULL){
+        printf("move: too many arguments\n");
+        return;
+    }
+    FILE *source, *target;
+    char ch;
+    source = fopen(arguments[1], "r");
+    if (source == NULL){
+        printf("move: cannot stat '%s': No such file or directory\n", arguments[1]);
+        return;
+    }
+    target = fopen(arguments[2], "w");
+    if (target == NULL){
+        printf("move: cannot create regular file '%s': No such file or directory\n", arguments[2]);
+        return;
+    }
+    while ((ch = fgetc(source)) != EOF){
+        fputc(ch, target);
+    }
+    fclose(source);
+    fclose(target);
+    printf("File moved successfully.\n");
+}
+

myFunction.h

@@ -43,4 +43,5 @@ void cp(char ** arguments);
 void delete(char **path);
 void get_dir();
 void SystemCall(char **arguments);
-void mypipe(char **argv1, char **argv2);
+void mypipe(char **argv1, char **argv2);
+void move(char **arguments);

myShell.c

@@ -23,6 +23,7 @@ int pipeCheck(char **arguments)
     {
         if (strcmp(arguments[i], "|") == 0)
         {
+            free(arguments[i]);// free the pipe character because we can't free null
             arguments[i] = NULL;
             return 1;
         }
@@ -85,10 +86,8 @@ int main()
         }
 
         char **arguments = splitArgument(input);
-
         int size = argumentArraySize(arguments);
         int isPipe = pipeCheck(arguments);
-
         if (strcmp(arguments[0], "exit") == 0){
             freeArguments(arguments);
             logout(input);
@@ -103,7 +102,10 @@ int main()
             delete(arguments);
         }else if (strcmp(arguments[0], "dir") == 0){
             get_dir();
-        }else if(isPipe){
+        }else if (strcmp(arguments[0], "mv") == 0){
+            move(arguments);
+        }
+        else if(isPipe){
             char ***args = splitArgumentsArray(arguments, size);
             mypipe(args[0], args[1]);
             wait(NULL);
@@ -112,19 +114,20 @@ int main()
                 free(args[i]);
             }
             free(args);
-            for (int i = 0; i < size; i++)
-            {
-                free(arguments[i]);
-            }
-            free(arguments);
         }
         else{
             SystemCall(arguments);
         }
-        if(isPipe == 0)
+        for (int i = 0; i < size; i++)
         {
-            freeArguments(arguments);
+            if(arguments[i] != NULL){
+            puts(arguments[i]);
+            }
+        }
+        for (int i = 0; i < size; i++) {
+            free(arguments[i]);
         }
+        free(arguments);
         free(input);
     }
     return 0;