Preload (audition) presets does not restore controllers

[riban-bw]

Describe the issue

There is the ability to preview / audition presets when highlighted in the preset view and a MIDI note on is received. This stores the currently selected preset and temporarily loads the new one. If the user has adjusted some parameters manually, changing from the last loaded preset, these parameter changes are not restored if they subsequently cancel from the preset menu.

To Reproduce

Steps to reproduce the behavior:

1. Enable Note-On Preset Preload in Admin menu.
2. Add an engine, e.g. MDA JX10.
3. Adjust a parameter, e.g. VCA Attack.
4. Access presets menu and highlight another preset.
5. Play a MIDI note to preview the selected preset.
6. Cancel from the preset menu.

Expected behaviour

Previous preset and parameter settings are restored.

Actual behaviour

Previous preset is restored without parameter adjustments.

Additional context

This may require saving a copy of the zctrl values in the processor, e.g. as a symbol=value dictionary.

Configuration

Hardware

Raspberry Pi 5 Model B Rev 1.0
Audio: Tascam US-16x08
Display: MIPI DSI 800x480
Wiring: TOUCH_ONLY
I2C: Not detected
Profile: v5

System

Debian GNU/Linux 12 (bookworm)
Build Date: 2024-10-02
Memory: 25% (2027M/8064M)
Internal Storage: 10% (22G/234G)
Temperature: 47.7ºC
Overclock: None

MIDI & UI

Tuning: 440 Hz
Master Channel: 15
Preload Presets: Off
ZS3 (SubSnapShots): On
Power Save: 10 minutes
Audio Levels on Snapshots: On

Software

zyncoder: vangelis (092fb26) 
zynthian-ui: vangelis (f37e51f)
zynthian-sys: vangelis (4b568b8)
zynthian-data: vangelis (bee88d0)
zynthian-webconf: vangelis (4dab315)

[riban-bw]

This is implemented in dev branch.

[johannesmenzel]

I tested this feature after you directed me in that direction and I really like the behaviour of this for auditioning presets. One minor thing I realized is that it always produces sound only from the second note-on message, the first one produces just a clicking sound. No catastrophe though.