Add latest changes from gitlab-org/gitlab@master

Author: GitLab Bot

.vale.ini

@@ -7,3 +7,6 @@ MinAlertLevel = suggestion
 
 [*.md]
 BasedOnStyles = gitlab
+
+# Ignore SVG markup
+TokenIgnores = (\*\*\{\w*\}\*\*)

doc/administration/consul.md

@@ -77,7 +77,7 @@ Identify any existing health issues in the cluster by running the following comm
 within each node. The command will return an empty array if the cluster is healthy:
 
 ```shell
-curl http://127.0.0.1:8500/v1/health/state/critical
+curl "http://127.0.0.1:8500/v1/health/state/critical"
 ```
 
 Consul nodes communicate using the raft protocol. If the current leader goes

doc/administration/geo/setup/database.md

@@ -151,7 +151,7 @@ There is an [issue where support is being discussed](https://gitlab.com/gitlab-o
    ##
    ## Public address
    ##
-   echo "External address: $(curl --silent ipinfo.io/ip)"
+   echo "External address: $(curl --silent "ipinfo.io/ip")"
    ```
 
    In most cases, the following addresses will be used to configure GitLab

doc/administration/invalidate_markdown_cache.md

@@ -19,5 +19,5 @@ be done by [changing the application settings through
 the API](../api/settings.md#change-application-settings):
 
 ```shell
-curl --request PUT --header "PRIVATE-TOKEN: <your_access_token>" https://gitlab.example.com/api/v4/application/settings?local_markdown_version=<increased_number>
+curl --request PUT --header "PRIVATE-TOKEN: <your_access_token>" "https://gitlab.example.com/api/v4/application/settings?local_markdown_version=<increased_number>"
 ```

doc/administration/operations/fast_ssh_key_lookup.md

@@ -139,7 +139,7 @@ the database. The following instructions can be used to build OpenSSH 7.5:
    ```shell
    sudo su -
    cd /tmp
-   curl --remote-name https://cdn.openbsd.org/pub/OpenBSD/OpenSSH/portable/openssh-7.5p1.tar.gz
+   curl --remote-name "https://cdn.openbsd.org/pub/OpenBSD/OpenSSH/portable/openssh-7.5p1.tar.gz"
    tar xzvf openssh-7.5p1.tar.gz
    yum install rpm-build gcc make wget openssl-devel krb5-devel pam-devel libX11-devel xmkmf libXt-devel
    ```

doc/administration/packages/container_registry.md

@@ -1155,8 +1155,8 @@ After adding the setting, [reconfigure GitLab](../restart_gitlab.md#omnibus-gitl
 Use curl to request debug output from the debug server:
 
 ```shell
-curl localhost:5001/debug/health
-curl localhost:5001/debug/vars
+curl "localhost:5001/debug/health"
+curl "localhost:5001/debug/vars"
 ```
 
 ### Advanced Troubleshooting
@@ -1236,7 +1236,7 @@ mitmproxy --port 9000
 This command runs mitmproxy on port `9000`. In another window, run:
 
 ```shell
-curl --proxy http://localhost:9000 https://httpbin.org/status/200
+curl --proxy "http://localhost:9000" "https://httpbin.org/status/200"
 ```
 
 If everything is set up correctly, information is displayed on the mitmproxy window and

doc/administration/reference_architectures/troubleshooting.md

@@ -434,13 +434,13 @@ If the monitoring node is not receiving any data, check that the exporters are
 capturing data.
 
 ```shell
-curl http[s]://localhost:<EXPORTER LISTENING PORT>/metric
+curl "http[s]://localhost:<EXPORTER LISTENING PORT>/metric"
 ```
 
 or
 
 ```shell
-curl http[s]://localhost:<EXPORTER LISTENING PORT>/-/metric
+curl "http[s]://localhost:<EXPORTER LISTENING PORT>/-/metric"
 ```
 
 ## Troubleshooting PgBouncer

doc/administration/snippets/index.md

@@ -64,11 +64,11 @@ The process to set the snippets size limit through the Application Settings API
 exactly the same as you would do to [update any other setting](../../api/settings.md#change-application-settings).
 
 ```shell
-curl --request PUT --header "PRIVATE-TOKEN: <your_access_token>" https://gitlab.example.com/api/v4/application/settings?snippet_size_limit=52428800
+curl --request PUT --header "PRIVATE-TOKEN: <your_access_token>" "https://gitlab.example.com/api/v4/application/settings?snippet_size_limit=52428800"
 ```
 
 You can also use the API to [retrieve the current value](../../api/settings.md#get-current-application-settings).
 
 ```shell
-curl --header "PRIVATE-TOKEN: <your_access_token>" https://gitlab.example.com/api/v4/application/settings
+curl --header "PRIVATE-TOKEN: <your_access_token>" "https://gitlab.example.com/api/v4/application/settings"
 ```

doc/administration/troubleshooting/linux_cheat_sheet.md

@@ -303,7 +303,7 @@ nslookup example.com 1.1.1.1
 whois <ip_address> | grep -i "orgname\|netname"
 
 # Curl headers with redirect
-curl --head --location https://example.com
+curl --head --location "https://example.com"
 ```
 
 ## Package Management

doc/administration/troubleshooting/ssl.md

@@ -24,7 +24,7 @@ following issues:
 - `curl` fails:
 
   ```shell
-  curl https://gitlab.domain.tld
+  curl "https://gitlab.domain.tld"
   curl: (60) SSL certificate problem: unable to get local issuer certificate
   More details here: https://curl.haxx.se/docs/sslcerts.html
   ```
@@ -125,7 +125,7 @@ The cause of the issue can be confirmed by checking if:
 - `curl` fails:
 
   ```shell
-  $ curl https://gitlab.domain.tld
+  $ curl "https://gitlab.domain.tld"
   curl: (60) SSL certificate problem: self signed certificate
   More details here: https://curl.haxx.se/docs/sslcerts.html
   ```

doc/administration/troubleshooting/test_environments.md

@@ -103,7 +103,7 @@ docker run -d --name elasticsearch \
 docker.elastic.co/elasticsearch/elasticsearch:5.5.1
 ```
 
-Then confirm it works in the browser at `curl http://<IP_ADDRESS>:9200/_cat/health`.
+Then confirm it works in the browser at `curl "http://<IP_ADDRESS>:9200/_cat/health"`.
 Elasticsearch's default username is `elastic` and password is `changeme`.
 
 ### Kroki

doc/administration/troubleshooting/tracing_correlation_id.md

@@ -59,7 +59,7 @@ interested in.
 If you're using `curl` then you can use the verbose option to show request and response headers, as well as other debug info.
 
 ```shell
-➜  ~ curl --verbose https://gitlab.example.com/api/v4/projects
+➜  ~ curl --verbose "https://gitlab.example.com/api/v4/projects"
 # look for a line that looks like this
 < x-request-id: 4rAMkV3gof4
 ```

doc/administration/wikis/index.md

@@ -65,11 +65,11 @@ The process to set the wiki page size limit through the Application Settings API
 exactly the same as you would do to [update any other setting](../../api/settings.md#change-application-settings).
 
 ```shell
-curl --request PUT --header "PRIVATE-TOKEN: <your_access_token>" https://gitlab.example.com/api/v4/application/settings?wiki_page_max_content_bytes=52428800
+curl --request PUT --header "PRIVATE-TOKEN: <your_access_token>" "https://gitlab.example.com/api/v4/application/settings?wiki_page_max_content_bytes=52428800"
 ```
 
 You can also use the API to [retrieve the current value](../../api/settings.md#get-current-application-settings).
 
 ```shell
-curl --header "PRIVATE-TOKEN: <your_access_token>" https://gitlab.example.com/api/v4/application/settings
+curl --header "PRIVATE-TOKEN: <your_access_token>" "https://gitlab.example.com/api/v4/application/settings"
 ```

doc/api/freeze_periods.md

@@ -138,7 +138,7 @@ Example request:
 ```shell
 curl --header 'Content-Type: application/json' --header "PRIVATE-TOKEN: <your_access_token>" \
      --data '{ "freeze_end": "0 8 * * 1" }' \
-     --request PUT https://gitlab.example.com/api/v4/projects/19/freeze_periods/1
+     --request PUT "https://gitlab.example.com/api/v4/projects/19/freeze_periods/1"
 ```
 
 Example response:

doc/api/metrics_user_starred_dashboards.md

@@ -26,7 +26,7 @@ Parameters:
 | `dashboard_path` | string        | yes      | URL-encoded path to file defining the dashboard which should be marked as favorite.   |
 
 ```shell
-curl --header 'Private-Token: <your_access_token>' https://gitlab.example.com/api/v4/projects/20/metrics/user_starred_dashboards \
+curl --header 'Private-Token: <your_access_token>' "https://gitlab.example.com/api/v4/projects/20/metrics/user_starred_dashboards" \
  --data-urlencode "dashboard_path=config/prometheus/dashboards/common_metrics.yml"
 ```
 
@@ -57,7 +57,7 @@ Parameters:
 | `dashboard_path` | string        | no      | URL-encoded path to file defining the dashboard which should no longer be marked as favorite. When not supplied, all dashboards within given projects are removed from favorites.   |
 
 ```shell
-curl --request DELETE --header 'Private-Token: <your_access_token>' https://gitlab.example.com/api/v4/projects/20/metrics/user_starred_dashboards \
+curl --request DELETE --header 'Private-Token: <your_access_token>' "https://gitlab.example.com/api/v4/projects/20/metrics/user_starred_dashboards" \
  --data-urlencode "dashboard_path=config/prometheus/dashboards/common_metrics.yml"
 ```
 

doc/ci/ci_cd_for_external_repos/bitbucket_integration.md

@@ -110,7 +110,7 @@ To use GitLab CI/CD with a Bitbucket Cloud repository:
    esac
 
    echo "Pushing status to $BITBUCKET_STATUS_API..."
-   curl --request POST $BITBUCKET_STATUS_API \
+   curl --request POST "$BITBUCKET_STATUS_API" \
    --user $BITBUCKET_USERNAME:$BITBUCKET_ACCESS_TOKEN \
    --header "Content-Type:application/json" \
    --silent \

doc/ci/examples/laravel_with_gitlab_and_envoy/index.md

@@ -417,7 +417,7 @@ RUN apt-get clean
 RUN docker-php-ext-install mcrypt pdo_mysql zip
 
 # Install Composer
-RUN curl --silent --show-error https://getcomposer.org/installer | php -- --install-dir=/usr/local/bin --filename=composer
+RUN curl --silent --show-error "https://getcomposer.org/installer" | php -- --install-dir=/usr/local/bin --filename=composer
 
 # Install Laravel Envoy
 RUN composer global require "laravel/envoy=~1.0"

doc/ci/examples/php.md

@@ -56,7 +56,7 @@ apt-get update -yqq
 apt-get install git -yqq
 
 # Install phpunit, the tool that we will use for testing
-curl --location --output /usr/local/bin/phpunit https://phar.phpunit.de/phpunit.phar
+curl --location --output /usr/local/bin/phpunit "https://phar.phpunit.de/phpunit.phar"
 chmod +x /usr/local/bin/phpunit
 
 # Install mysql driver

doc/ci/triggers/README.md

@@ -56,7 +56,7 @@ and it creates a dependent pipeline relation visible on the
 build_docs:
   stage: deploy
   script:
-    - curl --request POST --form "token=$CI_JOB_TOKEN" --form ref=master https://gitlab.example.com/api/v4/projects/9/trigger/pipeline
+    - curl --request POST --form "token=$CI_JOB_TOKEN" --form ref=master "https://gitlab.example.com/api/v4/projects/9/trigger/pipeline"
   only:
     - tags
 ```
@@ -143,7 +143,7 @@ By using cURL you can trigger a pipeline rerun with minimal effort, for example:
 curl --request POST \
      --form token=TOKEN \
      --form ref=master \
-     https://gitlab.example.com/api/v4/projects/9/trigger/pipeline
+     "https://gitlab.example.com/api/v4/projects/9/trigger/pipeline"
 ```
 
 In this case, the project with ID `9` gets rebuilt on `master` branch.
@@ -244,7 +244,7 @@ curl --request POST \
   --form token=TOKEN \
   --form ref=master \
   --form "variables[UPLOAD_TO_S3]=true" \
-  https://gitlab.example.com/api/v4/projects/9/trigger/pipeline
+  "https://gitlab.example.com/api/v4/projects/9/trigger/pipeline"
 ```
 
 Trigger variables have the [highest priority](../variables/README.md#priority-of-environment-variables)
@@ -257,7 +257,7 @@ in conjunction with cron. The example below triggers a job on the `master`
 branch of project with ID `9` every night at `00:30`:
 
 ```shell
-30 0 * * * curl --request POST --form token=TOKEN --form ref=master https://gitlab.example.com/api/v4/projects/9/trigger/pipeline
+30 0 * * * curl --request POST --form token=TOKEN --form ref=master "https://gitlab.example.com/api/v4/projects/9/trigger/pipeline"
 ```
 
 This behavior can also be achieved through GitLab's UI with

doc/ci/yaml/README.md

@@ -4257,7 +4257,7 @@ job_name:
     - *some-script-before
   script:
     - *some-script
-  before_script:
+  after_script:
     - *some-script-after
 ```
 

doc/development/chaos_endpoints.md

@@ -66,8 +66,8 @@ GET /-/chaos/leakmem?memory_mb=1024&duration_s=50&async=true
 | `async`      | boolean | no       | Set to true to leak memory in a Sidekiq background worker process                    |
 
 ```shell
-curl http://localhost:3000/-/chaos/leakmem?memory_mb=1024&duration_s=10 --header 'X-Chaos-Secret: secret'
-curl http://localhost:3000/-/chaos/leakmem?memory_mb=1024&duration_s=10&token=secret
+curl "http://localhost:3000/-/chaos/leakmem?memory_mb=1024&duration_s=10" --header 'X-Chaos-Secret: secret'
+curl "http://localhost:3000/-/chaos/leakmem?memory_mb=1024&duration_s=10&token=secret"
 ```
 
 ## CPU spin
@@ -89,8 +89,8 @@ GET /-/chaos/cpu_spin?duration_s=50&async=true
 | `async`      | boolean | no       | Set to true to consume CPU in a Sidekiq background worker process     |
 
 ```shell
-curl http://localhost:3000/-/chaos/cpu_spin?duration_s=60 --header 'X-Chaos-Secret: secret'
-curl http://localhost:3000/-/chaos/cpu_spin?duration_s=60&token=secret
+curl "http://localhost:3000/-/chaos/cpu_spin?duration_s=60" --header 'X-Chaos-Secret: secret'
+curl "http://localhost:3000/-/chaos/cpu_spin?duration_s=60&token=secret"
 ```
 
 ## DB spin
@@ -114,8 +114,8 @@ GET /-/chaos/db_spin?duration_s=50&async=true
 | `async`      | boolean | no       | Set to true to perform the operation in a Sidekiq background worker process |
 
 ```shell
-curl http://localhost:3000/-/chaos/db_spin?interval_s=1&duration_s=60 --header 'X-Chaos-Secret: secret'
-curl http://localhost:3000/-/chaos/db_spin?interval_s=1&duration_s=60&token=secret
+curl "http://localhost:3000/-/chaos/db_spin?interval_s=1&duration_s=60" --header 'X-Chaos-Secret: secret'
+curl "http://localhost:3000/-/chaos/db_spin?interval_s=1&duration_s=60&token=secret"
 ```
 
 ## Sleep
@@ -136,8 +136,8 @@ GET /-/chaos/sleep?duration_s=50&async=true
 | `async`      | boolean | no       | Set to true to sleep in a Sidekiq background worker process            |
 
 ```shell
-curl http://localhost:3000/-/chaos/sleep?duration_s=60 --header 'X-Chaos-Secret: secret'
-curl http://localhost:3000/-/chaos/sleep?duration_s=60&token=secret
+curl "http://localhost:3000/-/chaos/sleep?duration_s=60" --header 'X-Chaos-Secret: secret'
+curl "http://localhost:3000/-/chaos/sleep?duration_s=60&token=secret"
 ```
 
 ## Kill
@@ -157,6 +157,6 @@ GET /-/chaos/kill?async=true
 | `async`      | boolean | no       | Set to true to kill a Sidekiq background worker process                |
 
 ```shell
-curl http://localhost:3000/-/chaos/kill --header 'X-Chaos-Secret: secret'
-curl http://localhost:3000/-/chaos/kill?token=secret
+curl "http://localhost:3000/-/chaos/kill" --header 'X-Chaos-Secret: secret'
+curl "http://localhost:3000/-/chaos/kill?token=secret"
 ```

doc/development/gitaly.md

@@ -345,7 +345,7 @@ the integration by using GDK:
    1. Check that the list of current metrics has the new counter for the feature flag:
 
       ```shell
-      curl --silent http://localhost:9236/metrics | grep go_find_all_tags
+      curl --silent "http://localhost:9236/metrics" | grep go_find_all_tags
       ```
 
 1. Once you observe the metrics for the new feature flag and it increments, you
@@ -375,5 +375,5 @@ the integration by using GDK:
    1. Verify the feature is on by observing the metrics for it:
 
       ```shell
-      curl --silent http://localhost:9236/metrics | grep go_find_all_tags
+      curl --silent "http://localhost:9236/metrics" | grep go_find_all_tags
       ```

doc/development/internal_api.md

@@ -60,7 +60,7 @@ POST /internal/allowed
 Example request:
 
 ```shell
-curl --request POST --header "Gitlab-Shared-Secret: <Base64 encoded token>" --data "key_id=11&project=gnuwget/wget2&action=git-upload-pack&protocol=ssh" http://localhost:3001/api/v4/internal/allowed
+curl --request POST --header "Gitlab-Shared-Secret: <Base64 encoded token>" --data "key_id=11&project=gnuwget/wget2&action=git-upload-pack&protocol=ssh" "http://localhost:3001/api/v4/internal/allowed"
 ```
 
 Example response:
@@ -108,7 +108,7 @@ information for LFS clients when the repository is accessed over SSH.
 Example request:
 
 ```shell
-curl --request POST --header "Gitlab-Shared-Secret: <Base64 encoded token>" --data "key_id=11&project=gnuwget/wget2" http://localhost:3001/api/v4/internal/lfs_authenticate
+curl --request POST --header "Gitlab-Shared-Secret: <Base64 encoded token>" --data "key_id=11&project=gnuwget/wget2" "http://localhost:3001/api/v4/internal/lfs_authenticate"
 ```
 
 ```json
@@ -141,7 +141,7 @@ GET /internal/authorized_keys
 Example request:
 
 ```shell
-curl --request GET --header "Gitlab-Shared-Secret: <Base64 encoded secret>""http://localhost:3001/api/v4/internal/authorized_keys?key=<key as passed by OpenSSH>"
+curl --request GET --header "Gitlab-Shared-Secret: <Base64 encoded secret>" "http://localhost:3001/api/v4/internal/authorized_keys?key=<key as passed by OpenSSH>"
 ```
 
 Example response:
@@ -242,7 +242,7 @@ GET /internal/two_factor_recovery_codes
 Example request:
 
 ```shell
-curl --request POST --header "Gitlab-Shared-Secret: <Base64 encoded secret>" --data "key_id=7" http://localhost:3001/api/v4/internal/two_factor_recovery_codes
+curl --request POST --header "Gitlab-Shared-Secret: <Base64 encoded secret>" --data "key_id=7" "http://localhost:3001/api/v4/internal/two_factor_recovery_codes"
 ```
 
 Example response:
@@ -289,7 +289,7 @@ POST /internal/personal_access_token
 Example request:
 
 ```shell
-curl --request POST --header "Gitlab-Shared-Secret: <Base64 encoded secret>" --data "user_id=29&name=mytokenname&scopes[]=read_user&scopes[]=read_repository&expires_at=2020-07-24" http://localhost:3001/api/v4/internal/personal_access_token
+curl --request POST --header "Gitlab-Shared-Secret: <Base64 encoded secret>" --data "user_id=29&name=mytokenname&scopes[]=read_user&scopes[]=read_repository&expires_at=2020-07-24" "http://localhost:3001/api/v4/internal/personal_access_token"
 ```
 
 Example response:
@@ -323,7 +323,7 @@ POST /internal/pre_receive
 Example request:
 
 ```shell
-curl --request POST --header "Gitlab-Shared-Secret: <Base64 encoded secret>" --data "gl_repository=project-7" http://localhost:3001/api/v4/internal/pre_receive
+curl --request POST --header "Gitlab-Shared-Secret: <Base64 encoded secret>" --data "gl_repository=project-7" "http://localhost:3001/api/v4/internal/pre_receive"
 ```
 
 Example response:
@@ -355,7 +355,7 @@ POST /internal/post_receive
 Example Request:
 
 ```shell
-curl --request POST --header "Gitlab-Shared-Secret: <Base64 encoded secret>" --data "gl_repository=project-7" --data "identifier=user-1" --data "changes=0000000000000000000000000000000000000000 fd9e76b9136bdd9fe217061b497745792fe5a5ee gh-pages\n"  http://localhost:3001/api/v4/internal/post_receive
+curl --request POST --header "Gitlab-Shared-Secret: <Base64 encoded secret>" --data "gl_repository=project-7" --data "identifier=user-1" --data "changes=0000000000000000000000000000000000000000 fd9e76b9136bdd9fe217061b497745792fe5a5ee gh-pages\n" "http://localhost:3001/api/v4/internal/post_receive"
 ```
 
 Example response:

doc/development/python_guide/index.md

@@ -30,7 +30,7 @@ brew install pyenv
 To install `pyenv` on Linux, you can run the command below:
 
 ```shell
-curl https://pyenv.run | bash
+curl "https://pyenv.run" | bash
 ```
 
 Alternatively, you may find `pyenv` available as a system package via your distro package manager.