Skip to content

Commit 4938925

Browse files
author
GitLab Bot
committed
Add latest changes from gitlab-org/gitlab@master
1 parent f2fd07a commit 4938925

File tree

88 files changed

+1989
-1128
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

88 files changed

+1989
-1128
lines changed

.eslintignore

+2
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,6 @@
88
/vendor/
99
/sitespeed-result/
1010
/fixtures/**/*.graphql
11+
# Storybook build artifacts
12+
/storybook/public
1113
spec/fixtures/**/*.graphql

.gitlab/ci/rules.gitlab-ci.yml

+1
Original file line numberDiff line numberDiff line change
@@ -897,6 +897,7 @@
897897
rules:
898898
- !reference [".strict-ee-only-rules", rules]
899899
- !reference [".frontend:rules:default-frontend-jobs-as-if-foss", rules]
900+
- <<: *if-merge-request-labels-run-all-jest
900901
- <<: *if-merge-request
901902
changes: *frontend-patterns-for-as-if-foss
902903

.rubocop_todo/layout/line_length.yml

-1
Original file line numberDiff line numberDiff line change
@@ -1817,7 +1817,6 @@ Layout/LineLength:
18171817
- 'ee/spec/features/groups/scim_token_spec.rb'
18181818
- 'ee/spec/features/groups/security/compliance_dashboards_spec.rb'
18191819
- 'ee/spec/features/groups/sso_spec.rb'
1820-
- 'ee/spec/features/groups/usage_quotas_spec.rb'
18211820
- 'ee/spec/features/integrations/jira/jira_issues_list_spec.rb'
18221821
- 'ee/spec/features/invites_spec.rb'
18231822
- 'ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb'

.rubocop_todo/rspec/context_wording.yml

-2
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,8 @@ RSpec/ContextWording:
123123
- 'ee/spec/features/groups/push_rules_spec.rb'
124124
- 'ee/spec/features/groups/saml_enforcement_spec.rb'
125125
- 'ee/spec/features/groups/saml_providers_spec.rb'
126-
- 'ee/spec/features/groups/seat_usage/seat_usage_spec.rb'
127126
- 'ee/spec/features/groups/security/compliance_dashboards_spec.rb'
128127
- 'ee/spec/features/groups/sso_spec.rb'
129-
- 'ee/spec/features/groups/usage_quotas_spec.rb'
130128
- 'ee/spec/features/groups_spec.rb'
131129
- 'ee/spec/features/ide/user_commits_changes_spec.rb'
132130
- 'ee/spec/features/ide/user_opens_ide_spec.rb'

.rubocop_todo/rspec/empty_line_after_hook.yml

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ RSpec/EmptyLineAfterHook:
44
Exclude:
55
- 'ee/spec/controllers/projects/integrations/zentao/issues_controller_spec.rb'
66
- 'ee/spec/controllers/projects/push_rules_controller_spec.rb'
7-
- 'ee/spec/features/groups/usage_quotas_spec.rb'
87
- 'ee/spec/features/issues/user_bulk_edits_issues_spec.rb'
98
- 'ee/spec/features/profiles/usage_quotas_spec.rb'
109
- 'ee/spec/lib/ee/api/entities/user_with_admin_spec.rb'

GITLAB_METRICS_EXPORTER_VERSION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1cbf6d9ce79fe9df99b545529f7b7d754baea080
1+
af0cd47633f6e0a5b8ac349a2584c01164af701a

app/assets/javascripts/issues/show/components/fields/description.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export default {
6767
:quick-actions-docs-path="quickActionsDocsPath"
6868
:enable-autocomplete="enableAutocomplete"
6969
supports-quick-actions
70-
init-on-autofocus
70+
autofocus
7171
@input="$emit('input', $event)"
7272
@keydown.meta.enter="updateIssuable"
7373
@keydown.ctrl.enter="updateIssuable"

app/assets/javascripts/packages_and_registries/container_registry/explorer/components/list_page/registry_header.vue

+2-7
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,8 @@ export default {
9595
<template #right-actions>
9696
<slot name="commands"></slot>
9797
</template>
98-
<template #metadata-count>
99-
<metadata-item
100-
v-if="imagesCount"
101-
data-testid="images-count"
102-
icon="container-image"
103-
:text="imagesCountText"
104-
/>
98+
<template v-if="imagesCount" #metadata-count>
99+
<metadata-item data-testid="images-count" icon="container-image" :text="imagesCountText" />
105100
</template>
106101
<template #metadata-exp-policies>
107102
<metadata-item

app/assets/javascripts/pages/shared/wikis/components/wiki_form.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ export default {
343343
:uploads-path="pageInfo.uploadsPath"
344344
:enable-content-editor="isMarkdownFormat"
345345
:enable-preview="isMarkdownFormat"
346-
:init-on-autofocus="pageInfo.persisted"
346+
:autofocus="pageInfo.persisted"
347347
:form-field-placeholder="$options.i18n.content.placeholder"
348348
:form-field-aria-label="$options.i18n.content.label"
349349
form-field-id="wiki_content"

app/assets/javascripts/vue_shared/components/markdown/markdown_editor.vue

+13-13
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ export default {
7272
required: false,
7373
default: '',
7474
},
75-
initOnAutofocus: {
75+
autofocus: {
7676
type: Boolean,
7777
required: false,
7878
default: false,
@@ -87,20 +87,20 @@ export default {
8787
return {
8888
editingMode: EDITING_MODE_MARKDOWN_FIELD,
8989
switchEditingControlEnabled: true,
90-
autofocus: this.initOnAutofocus,
90+
autofocused: false,
9191
};
9292
},
9393
computed: {
9494
isContentEditorActive() {
9595
return this.enableContentEditor && this.editingMode === EDITING_MODE_CONTENT_EDITOR;
9696
},
97-
contentEditorAutofocus() {
97+
contentEditorAutofocused() {
9898
// Match textarea focus behavior
99-
return this.autofocus ? 'end' : false;
99+
return this.autofocus && !this.autofocused ? 'end' : false;
100100
},
101101
},
102102
mounted() {
103-
this.autofocusTextarea(this.editingMode);
103+
this.autofocusTextarea();
104104
},
105105
methods: {
106106
updateMarkdownFromContentEditor({ markdown }) {
@@ -120,23 +120,22 @@ export default {
120120
},
121121
onEditingModeChange(editingMode) {
122122
this.notifyEditingModeChange(editingMode);
123-
this.enableAutofocus(editingMode);
124123
},
125124
onEditingModeRestored(editingMode) {
126125
this.notifyEditingModeChange(editingMode);
127126
},
128127
notifyEditingModeChange(editingMode) {
129128
this.$emit(editingMode);
130129
},
131-
enableAutofocus(editingMode) {
132-
this.autofocus = true;
133-
this.autofocusTextarea(editingMode);
134-
},
135-
autofocusTextarea(editingMode) {
136-
if (this.autofocus && editingMode === EDITING_MODE_MARKDOWN_FIELD) {
130+
autofocusTextarea() {
131+
if (this.autofocus && this.editingMode === EDITING_MODE_MARKDOWN_FIELD) {
137132
this.$refs.textarea.focus();
133+
this.setEditorAsAutofocused();
138134
}
139135
},
136+
setEditorAsAutofocused() {
137+
this.autofocused = true;
138+
},
140139
},
141140
switchEditingControlOptions: [
142141
{ text: __('Source'), value: EDITING_MODE_MARKDOWN_FIELD },
@@ -197,7 +196,8 @@ export default {
197196
:render-markdown="renderMarkdown"
198197
:uploads-path="uploadsPath"
199198
:markdown="value"
200-
:autofocus="contentEditorAutofocus"
199+
:autofocus="contentEditorAutofocused"
200+
@initialized="setEditorAsAutofocused"
201201
@change="updateMarkdownFromContentEditor"
202202
@loading="disableSwitchEditingControl"
203203
@loadingSuccess="enableSwitchEditingControl"

app/assets/javascripts/work_items/components/work_item_description.vue

+17-5
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { __, s__ } from '~/locale';
88
import EditedAt from '~/issues/show/components/edited.vue';
99
import Tracking from '~/tracking';
1010
import MarkdownField from '~/vue_shared/components/markdown/field.vue';
11-
import workItemQuery from '../graphql/work_item.query.graphql';
11+
import { getWorkItemQuery } from '../utils';
1212
import updateWorkItemMutation from '../graphql/update_work_item.mutation.graphql';
1313
import { i18n, TRACKING_CATEGORY_SHOW, WIDGET_TYPE_DESCRIPTION } from '../constants';
1414
@@ -32,6 +32,15 @@ export default {
3232
type: String,
3333
required: true,
3434
},
35+
fetchByIid: {
36+
type: Boolean,
37+
required: false,
38+
default: false,
39+
},
40+
queryVariables: {
41+
type: Object,
42+
required: true,
43+
},
3544
},
3645
markdownDocsPath: helpPagePath('user/markdown'),
3746
data() {
@@ -45,11 +54,14 @@ export default {
4554
},
4655
apollo: {
4756
workItem: {
48-
query: workItemQuery,
57+
query() {
58+
return getWorkItemQuery(this.fetchByIid);
59+
},
4960
variables() {
50-
return {
51-
id: this.workItemId,
52-
};
61+
return this.queryVariables;
62+
},
63+
update(data) {
64+
return this.fetchByIid ? data.workspace.workItems.nodes[0] : data.workItem;
5365
},
5466
skip() {
5567
return !this.workItemId;

0 commit comments

Comments
 (0)