Add latest changes from gitlab-org/gitlab@master

Author: GitLab Bot

.rubocop_todo/gitlab/strong_memoize_attr.yml

@@ -647,7 +647,6 @@ Gitlab/StrongMemoizeAttr:
     - 'lib/gitlab/git_access_project.rb'
     - 'lib/gitlab/gitaly_client/with_feature_flag_actors.rb'
     - 'lib/gitlab/github_import/client.rb'
-    - 'lib/gitlab/github_import/importer/repository_importer.rb'
     - 'lib/gitlab/github_import/representation/diff_notes/suggestion_formatter.rb'
     - 'lib/gitlab/gl_repository/identifier.rb'
     - 'lib/gitlab/gpg/commit.rb'

.rubocop_todo/layout/argument_alignment.yml

@@ -2048,7 +2048,6 @@ Layout/ArgumentAlignment:
     - 'lib/gitlab/import_export/snippets_repo_restorer.rb'
     - 'lib/gitlab/import_export/snippets_repo_saver.rb'
     - 'lib/gitlab/issuable/clone/copy_resource_events_service.rb'
-    - 'lib/gitlab/legacy_github_import/importer.rb'
     - 'lib/gitlab/mail_room.rb'
     - 'lib/gitlab/markdown_cache/redis/store.rb'
     - 'lib/gitlab/memory/reports_uploader.rb'

.rubocop_todo/layout/line_length.yml

@@ -3062,7 +3062,6 @@ Layout/LineLength:
     - 'lib/gitlab/kubernetes/helm/pod.rb'
     - 'lib/gitlab/kubernetes/kubectl_cmd.rb'
     - 'lib/gitlab/kubernetes/pod_cmd.rb'
-    - 'lib/gitlab/legacy_github_import/importer.rb'
     - 'lib/gitlab/legacy_github_import/project_creator.rb'
     - 'lib/gitlab/local_and_remote_storage_migration/base_migrater.rb'
     - 'lib/gitlab/lograge/custom_options.rb'

.rubocop_todo/naming/heredoc_delimiter_naming.yml

@@ -50,7 +50,6 @@ Naming/HeredocDelimiterNaming:
     - 'rubocop/cop/default_scope.rb'
     - 'rubocop/cop/file_decompression.rb'
     - 'rubocop/cop/gitlab/httparty.rb'
-    - 'rubocop/cop/gitlab/json.rb'
     - 'rubocop/cop/gitlab/module_with_instance_variables.rb'
     - 'rubocop/cop/gitlab/predicate_memoization.rb'
     - 'spec/controllers/projects/pipelines_controller_spec.rb'

.rubocop_todo/performance/map_compact.yml

@@ -116,7 +116,6 @@ Performance/MapCompact:
     - 'lib/gitlab/jira_import/metadata_collector.rb'
     - 'lib/gitlab/json_cache.rb'
     - 'lib/gitlab/language_detection.rb'
-    - 'lib/gitlab/legacy_github_import/importer.rb'
     - 'lib/gitlab/private_commit_email.rb'
     - 'lib/gitlab/sql/pattern.rb'
     - 'lib/gitlab/url_blocker.rb'

.rubocop_todo/performance/string_include.yml

@@ -12,8 +12,6 @@ Rake/Require:
     - 'lib/tasks/gitlab/packages/migrate.rake'
     - 'lib/tasks/gitlab/pages.rake'
     - 'lib/tasks/gitlab/refresh_project_statistics_build_artifacts_size.rake'
-    - 'lib/tasks/gitlab/terraform/migrate.rake'
-    - 'lib/tasks/gitlab/tw/codeowners.rake'
     - 'lib/tasks/gitlab/x509/update.rake'
     - 'lib/tasks/import.rake'
     - 'lib/tasks/tokens.rake'

.rubocop_todo/rake/require.yml

@@ -5057,7 +5057,6 @@ RSpec/MissingFeatureCategory:
     - 'spec/lib/gitlab/legacy_github_import/branch_formatter_spec.rb'
     - 'spec/lib/gitlab/legacy_github_import/client_spec.rb'
     - 'spec/lib/gitlab/legacy_github_import/comment_formatter_spec.rb'
-    - 'spec/lib/gitlab/legacy_github_import/importer_spec.rb'
     - 'spec/lib/gitlab/legacy_github_import/issuable_formatter_spec.rb'
     - 'spec/lib/gitlab/legacy_github_import/issue_formatter_spec.rb'
     - 'spec/lib/gitlab/legacy_github_import/label_formatter_spec.rb'

.rubocop_todo/rspec/missing_feature_category.yml

@@ -891,7 +891,6 @@ Style/IfUnlessModifier:
     - 'lib/gitlab/jira_import.rb'
     - 'lib/gitlab/jira_import/base_importer.rb'
     - 'lib/gitlab/legacy_github_import/client.rb'
-    - 'lib/gitlab/legacy_github_import/importer.rb'
     - 'lib/gitlab/legacy_github_import/issuable_formatter.rb'
     - 'lib/gitlab/legacy_github_import/project_creator.rb'
     - 'lib/gitlab/lograge/custom_options.rb'

.rubocop_todo/style/if_unless_modifier.yml

@@ -1,6 +1,6 @@
 <script>
 import { GlFormCheckboxGroup, GlFormCheckbox } from '@gitlab/ui';
-import { mapState, mapActions } from 'vuex';
+import { mapState, mapActions, mapGetters } from 'vuex';
 import { intersection } from 'lodash';
 import { NAV_LINK_COUNT_DEFAULT_CLASSES, LABEL_DEFAULT_CLASSES } from '../constants';
 import { formatSearchResultCount } from '../../store/utils';
@@ -12,31 +12,29 @@ export default {
     GlFormCheckbox,
   },
   props: {
-    filterData: {
+    filtersData: {
       type: Object,
       required: true,
     },
   },
   computed: {
     ...mapState(['query']),
+    ...mapGetters(['queryLangugageFilters']),
     scope() {
       return this.query.scope;
     },
-    queryFilters() {
-      return this.query[this.filterData?.filterParam] || [];
-    },
     dataFilters() {
-      return Object.values(this.filterData?.filters || []);
+      return Object.values(this.filtersData?.filters || []);
     },
     flatDataFilterValues() {
       return this.dataFilters.map(({ value }) => value);
     },
     selectedFilter: {
       get() {
-        return intersection(this.flatDataFilterValues, this.queryFilters);
+        return intersection(this.flatDataFilterValues, this.queryLangugageFilters);
       },
       set(value) {
-        this.setQuery({ key: this.filterData?.filterParam, value });
+        this.setQuery({ key: this.filtersData?.filterParam, value });
       },
     },
     labelCountClasses() {
@@ -56,7 +54,7 @@ export default {
 
 <template>
   <div class="gl-mx-5">
-    <h5 class="gl-mt-0">{{ filterData.header }}</h5>
+    <h5 class="gl-mt-0">{{ filtersData.header }}</h5>
     <gl-form-checkbox-group v-model="selectedFilter">
       <gl-form-checkbox
         v-for="f in dataFilters"

app/assets/javascripts/search/sidebar/components/checkbox_filter.vue

@@ -27,10 +27,15 @@ export default {
     apply: __('Apply'),
     showingMax: sprintf(s__('GlobalSearch|Showing top %{maxItems}'), { maxItems: MAX_ITEM_LENGTH }),
     loadError: s__('GlobalSearch|Aggregations load error.'),
+    reset: s__('GlobalSearch|Reset filters'),
   },
   computed: {
     ...mapState(['aggregations', 'sidebarDirty']),
-    ...mapGetters(['langugageAggregationBuckets']),
+    ...mapGetters([
+      'langugageAggregationBuckets',
+      'currentUrlQueryHasLanguageFilters',
+      'queryLangugageFilters',
+    ]),
     hasBuckets() {
       return this.langugageAggregationBuckets.length > 0;
     },
@@ -55,18 +60,33 @@ export default {
     dividerClasses() {
       return [...HR_DEFAULT_CLASSES, ...ONLY_SHOW_MD];
     },
+    hasQueryFilters() {
+      return this.queryLangugageFilters.length > 0;
+    },
   },
   async created() {
     await this.fetchLanguageAggregation();
   },
   methods: {
-    ...mapActions(['applyQuery', 'fetchLanguageAggregation']),
+    ...mapActions([
+      'applyQuery',
+      'resetLanguageQuery',
+      'resetLanguageQueryWithRedirect',
+      'fetchLanguageAggregation',
+    ]),
     onShowMore() {
       this.showAll = true;
     },
     trimBuckets(length) {
       return this.langugageAggregationBuckets.slice(0, length);
     },
+    cleanResetFilters() {
+      if (this.currentUrlQueryHasLanguageFilters) {
+        return this.resetLanguageQueryWithRedirect();
+      }
+      this.showAll = false;
+      return this.resetLanguageQuery();
+    },
   },
   HR_DEFAULT_CLASSES,
 };
@@ -84,7 +104,7 @@ export default {
       class="gl-overflow-x-hidden gl-overflow-y-auto"
       :class="{ 'language-filter-max-height': showAll }"
     >
-      <checkbox-filter class="gl-px-5" :filter-data="filtersData" />
+      <checkbox-filter :filters-data="filtersData" />
       <span v-if="showAll && hasOverMax" data-testid="has-over-max-text">{{
         $options.i18n.showingMax
       }}</span>
@@ -106,7 +126,9 @@ export default {
     </div>
     <div v-if="!aggregations.error">
       <hr :class="$options.HR_DEFAULT_CLASSES" />
-      <div class="gl-display-flex gl-align-items-center gl-mt-4 gl-mx-5 gl-px-5">
+      <div
+        class="gl-display-flex gl-align-items-center gl-justify-content-space-between gl-mt-4 gl-mx-5"
+      >
         <gl-button
           category="primary"
           variant="confirm"
@@ -116,6 +138,16 @@ export default {
         >
           {{ $options.i18n.apply }}
         </gl-button>
+        <gl-button
+          category="tertiary"
+          variant="link"
+          size="small"
+          :disabled="!hasQueryFilters && !sidebarDirty"
+          data-testid="reset-button"
+          @click="cleanResetFilters"
+        >
+          {{ $options.i18n.reset }}
+        </gl-button>
       </div>
     </div>
   </gl-form>

app/assets/javascripts/search/sidebar/components/language_filter.vue

@@ -1,20 +1,17 @@
 import { languageFilterData } from '~/search/sidebar/constants/language_filter_data';
 
-export const convertFiltersData = (rawBuckets) => {
-  return rawBuckets.reduce(
-    (acc, bucket) => {
-      return {
-        ...acc,
-        filters: {
-          ...acc.filters,
-          [bucket.key.toUpperCase()]: {
-            label: bucket.key,
-            value: bucket.key,
-            count: bucket.count,
-          },
+export const convertFiltersData = (rawBuckets) =>
+  rawBuckets.reduce(
+    (acc, bucket) => ({
+      ...acc,
+      filters: {
+        ...acc.filters,
+        [bucket.key.toUpperCase()]: {
+          label: bucket.key,
+          value: bucket.key,
+          count: bucket.count,
         },
-      };
-    },
+      },
+    }),
     { ...languageFilterData, filters: {} },
   );
-};

app/assets/javascripts/search/sidebar/utils.js

@@ -4,6 +4,7 @@ import axios from '~/lib/utils/axios_utils';
 import { visitUrl, setUrlParams } from '~/lib/utils/url_utility';
 import { logError } from '~/lib/logger';
 import { __ } from '~/locale';
+import { languageFilterData } from '~/search/sidebar/constants/language_filter_data';
 import { GROUPS_LOCAL_STORAGE_KEY, PROJECTS_LOCAL_STORAGE_KEY, SIDEBAR_PARAMS } from './constants';
 import * as types from './mutation_types';
 import {
@@ -105,7 +106,17 @@ export const applyQuery = ({ state }) => {
 };
 
 export const resetQuery = ({ state }) => {
-  visitUrl(setUrlParams({ ...state.query, page: null, state: null, confidential: null }));
+  visitUrl(
+    setUrlParams({ ...state.query, page: null, state: null, confidential: null }, undefined, true),
+  );
+};
+
+export const resetLanguageQueryWithRedirect = ({ state }) => {
+  visitUrl(setUrlParams({ ...state.query, language: null }, undefined, true));
+};
+
+export const resetLanguageQuery = ({ commit }) => {
+  commit(types.SET_QUERY, { key: languageFilterData?.filterParam, value: [] });
 };
 
 export const fetchSidebarCount = ({ commit, state }) => {

app/assets/javascripts/search/store/actions.js

@@ -1,4 +1,6 @@
+import { has } from 'lodash';
 import { languageFilterData } from '~/search/sidebar/constants/language_filter_data';
+
 import { GROUPS_LOCAL_STORAGE_KEY, PROJECTS_LOCAL_STORAGE_KEY } from './constants';
 
 export const frequentGroups = (state) => {
@@ -16,3 +18,11 @@ export const langugageAggregationBuckets = (state) => {
     )?.buckets || []
   );
 };
+
+export const queryLangugageFilters = (state) => {
+  return state.query[languageFilterData.filterParam] || [];
+};
+
+export const currentUrlQueryHasLanguageFilters = (state) =>
+  has(state.urlQuery, languageFilterData.filterParam) &&
+  state.urlQuery[languageFilterData.filterParam]?.length > 0;

app/assets/javascripts/search/store/getters.js

@@ -24,7 +24,7 @@ export default {
     state.projects = [];
   },
   [types.SET_QUERY](state, { key, value }) {
-    state.query[key] = value;
+    state.query = { ...state.query, [key]: value };
   },
   [types.SET_SIDEBAR_DIRTY](state, value) {
     state.sidebarDirty = value;

app/assets/javascripts/search/store/mutations.js

@@ -1,3 +1,4 @@
+import { isEqual } from 'lodash';
 import AccessorUtilities from '~/lib/utils/accessor';
 import { formatNumber } from '~/locale';
 import { joinPaths } from '~/lib/utils/url_utility';
@@ -94,6 +95,10 @@ export const isSidebarDirty = (currentQuery, urlQuery) => {
     const userAddedParam = !urlQuery[param] && currentQuery[param];
     const userChangedExistingParam = urlQuery[param] && urlQuery[param] !== currentQuery[param];
 
+    if (Array.isArray(currentQuery[param]) || Array.isArray(urlQuery[param])) {
+      return !isEqual(currentQuery[param], urlQuery[param]);
+    }
+
     return userAddedParam || userChangedExistingParam;
   });
 };