feat: add shortcuts #120
Merged
feat: add shortcuts #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements keyboard shortcut support by adding new translation keys for shortcuts in multiple languages and updating associated UI text. Key changes include:
- New translation entries for keyboard shortcuts (e.g. show help, next item, etc.) across various language files.
- Minor adjustments to error messages for consistency.
- An update to the README to highlight keyboard shortcut support and provide logo attribution.
Reviewed Changes
Copilot reviewed 14 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/lib/i18n/langs/zh-Hans.ts | Added new keys for shortcuts in Simplified Chinese |
| frontend/src/lib/i18n/langs/sv.ts | Added new keys for shortcuts in Swedish |
| frontend/src/lib/i18n/langs/ru.ts | Added new keys for shortcuts in Russian |
| frontend/src/lib/i18n/langs/pt.ts | Added new keys for shortcuts in Portuguese |
| frontend/src/lib/i18n/langs/pt-BR.ts | Added new keys for shortcuts in Brazilian Portuguese |
| frontend/src/lib/i18n/langs/fr.ts | Added new keys for shortcuts in French |
| frontend/src/lib/i18n/langs/es.ts | Added new keys for shortcuts in Spanish |
| frontend/src/lib/i18n/langs/en.ts | Added new keys for shortcuts and adjusted error messages |
| frontend/src/lib/i18n/langs/de.ts | Added new keys for shortcuts in German |
| README.md | Updated README to mention keyboard shortcut support and logo attribution |
Files not reviewed (10)
- frontend/package.json: Language not supported
- frontend/pnpm-lock.yaml: Language not supported
- frontend/src/lib/components/ActionSearch.svelte: Language not supported
- frontend/src/lib/components/ItemActionBookmark.svelte: Language not supported
- frontend/src/lib/components/ItemActionMarkAllasRead.svelte: Language not supported
- frontend/src/lib/components/ItemActionUnread.svelte: Language not supported
- frontend/src/lib/components/ItemActionVisitLink.svelte: Language not supported
- frontend/src/lib/components/ItemList.svelte: Language not supported
- frontend/src/lib/components/ShortcutHelpModal.svelte: Language not supported
- frontend/src/lib/components/Sidebar.svelte: Language not supported
Comments suppressed due to low confidence (1)
frontend/src/lib/i18n/langs/en.ts:92
- [nitpick] Consider including the definite article for clarity (e.g. 'Cannot delete the default group') to maintain consistency with previous messaging.
'settings.groups.delete.error.delete_the_default': 'Cannot delete default group',
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11
shortcuts.mp4
Ref: