Skip to content

feat: make the password optional #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2025
Merged

feat: make the password optional #128

merged 3 commits into from
Apr 5, 2025

Conversation

0x2E
Copy link
Owner

@0x2E 0x2E commented Apr 4, 2025

Fix #29

@0x2E 0x2E requested review from Copilot and mtlynch April 4, 2025 14:33
Copilot

This comment was marked as outdated.

@0x2E 0x2E requested a review from Copilot April 4, 2025 14:34
Copilot

This comment was marked as outdated.

@0x2E 0x2E requested a review from Copilot April 4, 2025 14:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • .env.example: Language not supported
Comments suppressed due to low confidence (2)

api/api.go:74

  • [nitpick] The condition checking for a non-empty password hash is duplicated. Consider extracting this logic into a boolean flag (e.g., isPasswordSet) to improve clarity and reduce repetition.
if len(params.PasswordHash.Bytes()) != 0 {

api/api.go:95

  • [nitpick] The duplicate check for a non-empty password hash appears again. Refactoring this into a shared value would ensure consistency and ease future maintenance.
if len(params.PasswordHash.Bytes()) != 0 {

Copy link
Collaborator

@mtlynch mtlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0x2E 0x2E merged commit dd0d2e7 into main Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: make password auth optional
2 participants