Skip to content

Commit

Permalink
Add overrides to isolated pnpm lockfile (#88)
Browse files Browse the repository at this point in the history
  • Loading branch information
0x80 authored Jun 9, 2024
1 parent e937234 commit 174a8c9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "isolate-package",
"version": "1.16.0",
"version": "1.17.0-0",
"description": "Isolate a monorepo package with its shared dependencies to form a self-contained directory, compatible with Firebase deploy",
"author": "Thijs Koerselman",
"license": "MIT",
Expand Down
5 changes: 5 additions & 0 deletions src/lib/lockfile/helpers/generate-pnpm-lockfile.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,11 @@ export async function generatePnpmLockfile({
? await pruneLockfile_v9(lockfile, targetPackageManifest, ".")

Check failure on line 145 in src/lib/lockfile/helpers/generate-pnpm-lockfile.ts

View workflow job for this annotation

GitHub Actions / everything (18)

Expected 4 arguments, but got 3.
: await pruneLockfile_v8(lockfile, targetPackageManifest, ".");

Check failure on line 146 in src/lib/lockfile/helpers/generate-pnpm-lockfile.ts

View workflow job for this annotation

GitHub Actions / everything (18)

Argument of type 'Lockfile | Lockfile' is not assignable to parameter of type 'Lockfile'.

/** Pruning seems to remove the overrides from the lockfile */
if (lockfile.overrides) {
prunedLockfile.overrides = lockfile.overrides;
}

/**
* Don't know how to map the patched dependencies yet, so we just include
* them but I don't think it would work like this. The important thing for
Expand Down

0 comments on commit 174a8c9

Please sign in to comment.