Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use last line as fileName when packing #115

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Only use last line as fileName when packing #115

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef900c0
Fixes #114 - only use last line as fileName
hjellek Nov 25, 2024
aeda065
Log and throw error if last line is empty or undefined
hjellek Nov 26, 2024
5e6faca
Access last element through at(-1) instead of pop
hjellek Nov 26, 2024
006ac38
Only throw error, changed error message
hjellek Nov 28, 2024
72c8bfc
Ran format
hjellek Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/lib/utils/pack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,13 @@ export async function pack(srcDir: string, dstDir: string) {
);
});

const lastLine = stdout.trim().split("\n").pop() || "";
const lastLine = stdout.trim().split("\n").at(-1)
if (!lastLine) {
log.error(
`Failed to parse last line from stdout: ${stdout.trim()}`
);
throw new Error("Unable to find fileName from pack output");
Copy link
Owner

@0x80 0x80 Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a need to log and throw, as the thrown error message should appear anyway.

Please throw the message from log.error, as it is more informative.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand exactly what you want me to do - only log, or only throw?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only throw, but throw an error with the message that you currently use in log.error. Thanks!

Copy link
Owner

@0x80 0x80 Nov 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... unless you can convince me that logging + throwing has a clear benefit. I never do that myself(*), but that doesn't mean I'm right necessarily ;)

(*) Unless the thrown error ends up being visible to the end-user and the system needs to log more/sensitive information internally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, updated!

Well, I guess it depends on the error and log handling in general so I just did it both 😅
As you say, sometimes the error is shown to the user and the log message can contain more useful stuff for debugging.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run prettier (pnpm format) to make the checks pass, then I can merge it...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

And thank you for your swift response, and efforts on the library in general 😊

}
const fileName = path.basename(lastLine);

const filePath = path.join(dstDir, fileName);
Expand Down