Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Windows Git Bash w/ pnpm #116

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

jack1323
Copy link
Contributor

I want to say upfront that this tool is fantastic, and so is the typescript mono repo example. I was able to finally restructure my mono-repo the way I've been hoping to and remove all my home-grown firebase publishing hacks.

This PR addresses problems I had with "packages/common" in a Windows git bash environment using pnpm. Naturally, both changes have to do with forward vs back slashes.

@0x80 0x80 self-requested a review December 14, 2024 08:34
Copy link
Owner

@0x80 0x80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution! LGTM. I don't see an easy way to test this, so I'm just going to take your word for it ;)

@0x80 0x80 self-requested a review December 14, 2024 08:36
Copy link
Owner

@0x80 0x80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the checks lint / formatting check succeeds

@jack1323
Copy link
Contributor Author

lint & lint:format are now passing

@0x80 0x80 merged commit 8a36324 into 0x80:main Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants