Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default constants and update ProverStateBuilder::default() description #21

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

Nashtare
Copy link
Contributor

@Nashtare Nashtare commented Feb 6, 2024

cf Jira ticket

Default parameters are now sufficient for any transaction (as we should expect default values to be), and added explanation about the tradeoff memory consumption / provable transactions.

@Nashtare Nashtare changed the title Change default constants and update ProverStateBuilder::default() description Change default constants and update ProverStateBuilder::default() description Feb 6, 2024
@Nashtare
Copy link
Contributor Author

Nashtare commented Feb 6, 2024

The CI failure is due to latest nightly, same issue on plonky2 side. Let me pin the nightly version first.

@Nashtare Nashtare requested a review from BGluth February 6, 2024 21:07
@Nashtare Nashtare self-assigned this Feb 6, 2024
@Nashtare Nashtare merged commit 58e9fa6 into 0xPolygonZero:main Feb 6, 2024
0 of 2 checks passed
@Nashtare Nashtare deleted the constants branch February 6, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants