Remove blobbasefee from block header
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: evm_arithmetization
Nashtare
force-pushed
the
blobbasefee_no_header
branch
from
9d7349a to
11d5ad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per EIP-7516,
blobbasefeeshould be retrieved from theexcess_blob_gasstored in the block header, but is not a header field on its own.The details on how this is computed are in EIP-4844.
For simplicity with higher layers of the stack, it's probably better to remove it from the plonky2 header to keep it as consistent as possible with an actual chain header. It's still taken as a prover input though, as blob fee market mechanism isn't implemented.