Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ci shellcheck #753

Merged
merged 11 commits into from
Nov 4, 2024
Merged

feat: add ci shellcheck #753

merged 11 commits into from
Nov 4, 2024

Conversation

atanmarko
Copy link
Member

Resolves #744

@atanmarko atanmarko added this to the System strengthening milestone Oct 28, 2024
@atanmarko atanmarko self-assigned this Oct 28, 2024
@github-actions github-actions bot added the ci label Oct 28, 2024
Copy link
Contributor

@0xaatif 0xaatif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Wibni version pinning

@atanmarko atanmarko marked this pull request as draft October 28, 2024 12:52
@atanmarko atanmarko marked this pull request as ready for review October 28, 2024 13:44
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

scripts/prove_stdio.sh Outdated Show resolved Hide resolved
@atanmarko atanmarko force-pushed the feat/add-ci-shellcheck branch from e3a3423 to 980ee03 Compare November 4, 2024 09:09
@atanmarko atanmarko merged commit c38c0c6 into develop Nov 4, 2024
23 checks passed
@atanmarko atanmarko deleted the feat/add-ci-shellcheck branch November 4, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Shellcheck in CI
3 participants