Fix/440 Per-image customization for quality, size, and style in Image Generation #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisal-alvi
requested review from
a team and
peterwilsoncc
and removed request for
a team and
peterwilsoncc
/home/runner/work/classifai/classifai/src/js/features/image-generation/media-modal/collections/images.js Error: 16:2 error Missing JSDoc @param "quality" declaration jsdoc/require-param Error: 16:2 error Missing JSDoc @param "size" declaration jsdoc/require-param Error: 16:2 error Missing JSDoc @param "style" declaration jsdoc/require-param /home/runner/work/classifai/classifai/src/js/features/image-generation/media-modal/views/generated-images-container.js Error: 31:31 error Replace `·this.prompt,·this.quality,·this.size,·this.style·` with `⏎↹↹↹this.prompt,⏎↹↹↹this.quality,⏎↹↹↹this.size,⏎↹↹↹this.style⏎↹↹` prettier/prettier ✖ 4 problems (4 errors, 0 warnings) 4 errors and 0 warnings potentially fixable with the `--fix` option. Error: Process completed with exit code 1.
FILE: includes/Classifai/Features/ImageGeneration.php ----------------------------------------------------------------------------------------------- FOUND 6 ERRORS AND 0 WARNINGS AFFECTING 6 LINES ----------------------------------------------------------------------------------------------- 316 | ERROR | Line indented incorrectly; expected 8 tabs, found 9 (Generic.WhiteSpace.ScopeIndent.IncorrectExact) 318 | ERROR | Line indented incorrectly; expected 8 tabs, found 9 (Generic.WhiteSpace.ScopeIndent.IncorrectExact) 328 | ERROR | Line indented incorrectly; expected 8 tabs, found 9 (Generic.WhiteSpace.ScopeIndent.IncorrectExact) 330 | ERROR | Line indented incorrectly; expected 8 tabs, found 9 (Generic.WhiteSpace.ScopeIndent.IncorrectExact) 340 | ERROR | Line indented incorrectly; expected 8 tabs, found 9 (Generic.WhiteSpace.ScopeIndent.IncorrectExact) 342 | ERROR | Line indented incorrectly; expected 8 tabs, found 9 (Generic.WhiteSpace.ScopeIndent.IncorrectExact) ----------------------------------------------------------------------------------------------- Error: Process completed with exit code 1.
/home/runner/work/classifai/classifai/src/js/features/image-generation/media-modal/collections/images.js Error: 16:2 error Expected JSDoc block lines to be aligned jsdoc/check-line-alignment
faisal-alvi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR enhances the Image Generation feature by allowing users to modify image quality, size, and style directly from the media modal. Previously, these options were only configurable at the global settings level, requiring users to change settings manually before generating an image and then reverting them if needed.
Closes #440
How to test the Change
Changelog Entry
Credits
Props @dkotter @jeffpaul @faisal-alvi
Checklist: