Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: make log filter async friendly by adding logAsync #3141

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add: make log filter async friendly by adding logAsync #3141

wants to merge 3 commits into from

Commits on Dec 31, 2023

  1. add: make log filter async friendly by adding logAsync 

    Right now the `log` filter logs the passed in values directly. This isn't always helpful when working with async values e.g. in webc components.
This change adds the `logAsync` filter to also take promises as any value and awaits them, so you always get some useful output.

It could be possible to just eagerly return the value in the sync filter and then use a `.then` call to log the values, but that would leave room for unexpected data mutation, so I didn't implement it that way for now.

Signed-off-by: Raphael Höser <[email protected]>
    @Snapstromegon
    Snapstromegon committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    c36191d View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Make the log filter implementation async 

    Signed-off-by: Raphael Höser <[email protected]>
    @Snapstromegon
    Snapstromegon committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    602c480 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Transform log filter to be opionally async friendly.

    @Snapstromegon
    Snapstromegon authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    c62dc6c View commit details
    Browse the repository at this point in the history