🐛 Don't cast empty strings to 0 values in numeric Field types

CHANGELOG.md

@@ -8,6 +8,7 @@
 * The `Alchemy.ClientSession` class should now be used as a map to store session data
 * Fix `Field.Schema` contents not being converted from database representation when the schema also has a relation
 * Make `Criteria#contains(value)` work as expected on array fields
+* Don't cast empty strings to `0` values in numeric `Field` types
 
 ## 1.3.22 (2023-12-21)
 

lib/app/helper_field/10-number_field.js

@@ -7,9 +7,7 @@
  * @since    0.2.0
  * @version  1.1.0
  */
-var NumberField = Function.inherits('Alchemy.Field', function Number(schema, name, options) {
-	Number.super.call(this, schema, name, options);
-});
+const NumberField = Function.inherits('Alchemy.Field', 'Number');
 
 /**
  * Set the datatype name
@@ -25,14 +23,18 @@ NumberField.setDatatype('number');
  *
  * @author   Jelle De Loecker <[email protected]>
  * @since    0.2.0
- * @version  0.4.1
+ * @version  1.4.0
  *
- * @param    {Mixed}   value
+ * @param    {*}   value
  *
  * @return   {number}
  */
 NumberField.setMethod(function cast(value) {
 
+	if (value === '') {
+		value = null;
+	}
+
 	// Allow null
 	if (value == null) {
 		return value;

lib/app/helper_field/20-decimal_field.js

@@ -14,14 +14,18 @@ const DecimalField = Function.inherits('Alchemy.Field.Number', 'Decimal');
  *
  * @author   Jelle De Loecker <[email protected]>
  * @since    1.3.20
- * @version  1.3.20
+ * @version  1.4.0
  *
  * @param    {Mixed}   value
  *
  * @return   {Decimal}
  */
 DecimalField.setMethod(function cast(value) {
 
+	if (value === '') {
+		value = null;
+	}
+
 	// Allow null
 	if (value == null) {
 		return value;

lib/app/helper_field/big_int_field.js

@@ -29,14 +29,18 @@ BigIntField.setDatatype('bigint');
  *
  * @author   Jelle De Loecker <[email protected]>
  * @since    1.3.6
- * @version  1.3.6
+ * @version  1.4.0
  *
  * @param    {Mixed}   value
  *
  * @return   {BigInt}
  */
 BigIntField.setMethod(function cast(value) {
 
+	if (value === '') {
+		value = null;
+	}
+
 	// Allow null
 	if (value == null) {
 		return value;

lib/app/helper_field/fixed_decimal_field.js

@@ -21,14 +21,18 @@ const FixedDecimalField = Function.inherits('Alchemy.Field.Decimal', function Fi
  *
  * @author   Jelle De Loecker <[email protected]>
  * @since    1.3.20
- * @version  1.3.20
+ * @version  1.4.0
  *
  * @param    {Mixed}   value
  *
  * @return   {Decimal}
  */
 FixedDecimalField.setMethod(function cast(value) {
 
+	if (value === '') {
+		value = null;
+	}
+
 	// Allow null
 	if (value == null) {
 		return value;

lib/app/helper_field/integer_field.js

@@ -7,23 +7,25 @@
  * @since    1.1.0
  * @version  1.1.0
  */
-var IntegerField = Function.inherits('Alchemy.Field.Number', function Integer(schema, name, options) {
-	Integer.super.call(this, schema, name, options);
-});
+const IntegerField = Function.inherits('Alchemy.Field.Number', 'Integer');
 
 /**
  * Cast the given value to this field's type
  *
  * @author   Jelle De Loecker <[email protected]>
  * @since    1.1.0
- * @version  1.1.0
+ * @version  1.4.0
  *
- * @param    {Mixed}   value
+ * @param    {*}   value
  *
  * @return   {number}
  */
 IntegerField.setMethod(function cast(value) {
 
+	if (value === '') {
+		value = null;
+	}
+
 	// Allow null
 	if (value == null) {
 		return value;