LG-10965: Show backup code reminder for partner-initiated requests #11744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
force-pushed
the
aduth-lg-10965-backup-code-reminder
branch
from
87c58ac to
ff75b13
Compare
aduth
force-pushed
the
aduth-lg-10965-backup-code-reminder-auth
branch
from
8cdbe61 to
c1e2c48
Compare
changelog: User-Facing Improvements, Backup Codes, Show backup code reminder for partner-initiated requests
aduth
force-pushed
the
aduth-lg-10965-backup-code-reminder-auth
branch
from
c1e2c48 to
99242b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10965
🛠 Summary of changes
Updates backup code reminder screen to use new controller actions implemented in #11738 to support use with sign-ins associated with a partner application, and updated after-sign-in logic to include partner-associated sign-ins to be considered for backup code reminder.
Temporarily merges to #11738.This cannot be merged until those changes are fully deployed to production.📜 Testing Plan
Repeat testing plan from #11738, but also verify that it shows reminder when initiating sign-in from partner application (e.g. sample OIDC application), and that you eventually return to the partner application after making your reminder choice.
👀 Screenshots
Note the partner logo in the screenshot, indicating that it is a partner-associated sign-in request: