Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pinpoint supported countries #11774

Merged
merged 9 commits into from
Jan 21, 2025
Merged

Update Pinpoint supported countries #11774

merged 9 commits into from
Jan 21, 2025
+45 −17

Conversation

zachmargolis
Copy link
Contributor

Related to #11772, I ran the requisite updating.

I made this a separate PR just in case there were countries we didn't want to enable due to shortcodes, agreements, etc

@zachmargolis
Update Pinpoint supported countries
16eedaa 
- Run `make lint_country_dialing_codes`

changelog: User-Facing Improvements, SMS support, Update list of supported countries for SMS
@zachmargolis zachmargolis requested review from a team January 17, 2025 21:13
@zachmargolis zachmargolis mentioned this pull request Jan 17, 2025
Merged
@mitchellhenke
Copy link
Contributor

How many of these are due to footnote changes/additions on the page? It looks like the Registration required1 has changed and there are some additional footnotes added. We'll probably want to better understand what those changes mean before applying any support changes here.

Current page: https://docs.aws.amazon.com/sms-voice/latest/userguide/phone-numbers-sms-by-country.html
Older page (via the Internet Archive): https://web.archive.org/web/20240306205730/https://docs.aws.amazon.com/sms-voice/latest/userguide/phone-numbers-sms-by-country.html

@zachmargolis
Copy link
Contributor Author

How many of these are due to footnote changes/additions on the page? It looks like the Registration required1 has changed and there are some additional footnotes added. We'll probably want to better understand what those changes mean before applying any support changes here.

yeah looks like we need to add support to our code to handle for Registration required^9

@zachmargolis zachmargolis merged commit 985030a into main Jan 21, 2025
2 checks passed
@zachmargolis zachmargolis deleted the margolis-updated-supported-countries branch January 21, 2025 21:33
@jmdembe jmdembe mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchellhenke mitchellhenke mitchellhenke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachmargolis @mitchellhenke