Jmax/lg 15676 passport api health check infrastructure #11891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`HealthCheckResponseOk` and `HealthCheckResponseFailure`
jmax-gsa
force-pushed
the
jmax/LG-15676-passport-api-health-check-infrastructure
branch
from
d42ba8b to
4acc77c
Compare
[skip changelog]
jmax-gsa
force-pushed
the
jmax/LG-15676-passport-api-health-check-infrastructure
branch
from
bfa7c30 to
d5efe7c
Compare
jmax-gsa
force-pushed
the
jmax/LG-15676-passport-api-health-check-infrastructure
branch
from
3bb4f24 to
b4ed521
Compare
amirbey
reviewed
Feb 20, 2025
| @@ -285,6 +285,7 @@ outbound_connection_check_retry_count: 2 | |||
| outbound_connection_check_timeout: 5 | |||
| outbound_connection_check_url: 'https://checkip.amazonaws.com' | |||
| participate_in_dap: false | |||
| passports_api_health_check_endpoint: 'https://caapinpe.state.gov/api/passport-match-prc-api/v1/html' | |||
There was a problem hiding this comment.
Suggested change
| passports_api_health_check_endpoint: 'https://caapinpe.state.gov/api/passport-match-prc-api/v1/html' | |
| passports_api_health_check_endpoint: '' |
amirbey
reviewed
Feb 20, 2025
| @@ -0,0 +1,41 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module DocAuth | |||
There was a problem hiding this comment.
this file to be deleted after namespace change?
amirbey
reviewed
Feb 20, 2025
|
|
||
| def connection | ||
| @connection ||= Faraday::Connection.new( | ||
| url: IdentityConfig.store.passports_api_health_check_endpoint, |
There was a problem hiding this comment.
there are 2 healthcheck endpoints for which we need to be able to check ...
there is also a composite healthcheck endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15676
🛠 Summary of changes
Added request and response classes for the Dos passport API health check
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
fetchon the health check request (see below). Verify that the connecton eventually times out, and that thefetchcall returned aHealthCheckFailurewith a Faraday network error.