add RoundTitle component #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesnitsky
requested review from
DaQuirm,
kirilknysh,
Shastel,
andrei-yanovich,
KantinDmitry and
humanamburu
DaQuirm
reviewed
Nov 4, 2017
|
|
||
| <style jsx>{` | ||
| p { | ||
| font-size: 1.5em; |
There was a problem hiding this comment.
Maybe it's better to use rems here so that PuzzleTitle's font size doesn't depend on that of the containing component? Unless that's actually what we want.
kirilknysh
reviewed
Nov 4, 2017
| } | ||
|
|
||
| .puzzle-title { | ||
| color: #f8d940; |
There was a problem hiding this comment.
Should it be a part of /src/styles/colour-palette.js ?
There was a problem hiding this comment.
my plan is to address all issues of this kind in scope of #20
lesnitsky
force-pushed
the
feature/round-title
branch
from
93a281f to
0941a79
Compare
DaQuirm
approved these changes
Nov 4, 2017
kirilknysh
approved these changes
Nov 4, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.