[BC brake] Avoid DB for configuration #108
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from
aacotroneo/laravel-saml2
I discovered multiple issues in this package:only environment specific details changing and overall being not cloud native friendly
I believe storing IDP configuration in the DB complicates a lot of things and most importantly makes it harder to maintain this project.
I've tried to consider reasons behind that move but couldn't find any. So now I'm proposing revert back to the
v1
approach and get rid of the DB as the configuration storage.Targeting
master
to simplify review, but significance of the change definitely warrant a new major version release. I know there was a start onv3
in #88 , but still believe the project and it's users would benefit from the simplicity and additional features that this change brings: