-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shell scripts compatibility enhancements #11
base: master
Are you sure you want to change the base?
Shell scripts compatibility enhancements #11
Conversation
E.g. fails on Ubuntu where /bin/sh is mapped to dash)
Wow! I've got a pretty busy week ahead but I'll try and look this over on the weekend. Thanks for the contribution! |
I think from reviewing some of the commits here and some of the other forks it would be worth thinking about a different command structure. I don't want to overburden the repo with loads of small script files when it might be simpler to have a single entry point and pass command line parameters (which could override the defaults in On other fronts, I'm all for having a more cross-platform script so thanks for making me consider those cases more. |
(Side note: I like commit messages to be formatted like git manual guidelines with a short < 50 character first line message. So I've gone ahead and reworded the commits) Cheers for the PR! |
Here are some changes in attempt to make the setup shell scripts more portable (in particular - compatible with Ubuntu 13.10).
.
instead ofsource
to loadvars.sh
. Seemssource
is not POSIX compatible. (In particular - it's not part ofdash
shell which is the default shell mapped to/bin/bash
in recent versions of Debian and Ubuntu). (Another alternative would be to explicitly require some other shell likebash
orzsh
instead ofsh
)