[Admin] Add anchors to repositories page #5427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests have to be addded |
rldhont
force-pushed
the
admin-repositories-anchors
branch
from
37fecb8 to
7832151
Compare
|
e2e tests added |
Gustry
reviewed
Feb 18, 2025
There was a problem hiding this comment.
Can you also edit https://github.com/3liz/lizmap-web-client/blob/master/lizmap/modules/admin/templates/project_list_zone.tpl#L80
in the admin panel → project list
rldhont
force-pushed
the
admin-repositories-anchors
branch
from
7832151 to
15a6cee
Compare
|
@Gustry thanks for review |
Gustry
requested changes
Feb 18, 2025
|
Side note, I will try to add the same behavior as on many websites, with visible anchor link, like https://github.com/3liz/lizmap-web-client/?tab=readme-ov-file
|
To easily come back to the right position in the repositories page, anchors has been added.
rldhont
force-pushed
the
admin-repositories-anchors
branch
from
15a6cee to
b3a1371
Compare
Gustry
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To easily come back to the right position in the repositories page, anchors has been added.