Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approve PullRequest in Danger step #53

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,15 @@ jobs:
if: ${{ !cancelled() }}
runs-on: ubuntu-latest
steps:
- uses: actions/create-github-app-token@v1
id: app-token
with:
app-id: ${{ secrets.BOT_APP_ID }}
private-key: ${{ secrets.BOT_PRIVATE_KEY }}
- name: Set token to env
run: echo GH_TOKEN=${{ steps.app-token.outputs.token }} >> $GITHUB_ENV
- uses: actions/checkout@v4
- name: Danger
uses: 417-72KI/[email protected]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ env.GH_TOKEN }}
23 changes: 22 additions & 1 deletion Dangerfile.swift
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ import Danger
let danger = Danger()

// fileImport: DangerfileExtensions/Git+Extension.swift
// fileImport: DangerfileExtensions/OctoKit+Extension.swift

SwiftLint.lint(inline: true)
// SwiftLint.lint(inline: true)

// Make it more obvious that a PR is a work in progress and shouldn't be merged yet
if let github = danger.github {
Expand All @@ -25,3 +26,23 @@ if danger.git.modifiedFiles.contains("LICENSE") {
if danger.git.deletedFiles.contains("LICENSE") {
danger.fail("Do not delete LICENSE !!")
}

if (danger.warnings + danger.fails).isEmpty,
let github = danger.github {
do {
let repo = github.pullRequest.base.repo
let pullRequestNumber = github.pullRequest.number

let review = try await github.api.postReview(
owner: repo.owner.login,
repository: repo.name,
pullRequestNumber: pullRequestNumber,
event: .approve
)
print(review)
} catch {
print(error)
danger.fail(error.localizedDescription)
danger.fail("\(error)")
}
}
117 changes: 117 additions & 0 deletions DangerfileExtensions/OctoKit+Extension.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
import Danger
import OctoKit
import RequestKit

extension Octokit {
@discardableResult
func postReview(
owner: String,
repository: String,
pullRequestNumber: Int,
commitId: String? = nil,
event: Review.Event,
body: String? = nil,
comments: [Review.Comment] = []
) async throws -> Review {
let router = ReviewRouter.postReview(configuration, owner, repository, pullRequestNumber, commitId, event, body, comments)
print(router)
return try await router.load(dateDecodingStrategy: .formatted(Time.rfc3339DateFormatter), expectedResultType: Review.self)
}
}

// MARK: -
extension Review {
enum Event: String, Codable {
case approve = "APPROVE"
case requestChanges = "REQUEST_CHANGES"
case comment = "COMMENT"
case pending = "PENDING"
}

struct Comment: Codable {
var path: String
var position: Int?
var body: String
var line: Int?
var side: String?
var startLine: Int?
var startSide: String?
}
}

extension Review.Comment {
enum CodingKeys: String, CodingKey {
case path
case position
case body
case line
case side
case startLine = "start_line"
case startSide = "start_side"
}
}

// MARK: -
private enum ReviewRouter {
// swiftlint:disable:next enum_case_associated_values_count discouraged_optional_collection
case postReview(Configuration, String, String, Int, String?, Review.Event?, String?, [Review.Comment]?)
}

extension ReviewRouter: JSONPostRouter {
var method: HTTPMethod { .POST }
var encoding: HTTPEncoding { .json }
var configuration: Configuration {
switch self {
case let .postReview(config, _, _, _, _, _, _, _):
return config
}
}

var params: [String: Any] {
switch self {
case let .postReview(_, _, _, _, commitId, event, body, comments):
var parameters = [String: Any]()
if let commitId = commitId {
parameters["commit_id"] = commitId
}
if let event = event {
parameters["event"] = event.rawValue
}
if let body = body {
parameters["body"] = body
}
if let comments = comments {
parameters["comments"] = comments.map { comment -> [String: Any] in
var parameters: [String: Any] = [
"path": comment.path,
"body": comment.body
]
if let position = comment.position {
parameters["position"] = position
}
if let line = comment.line {
parameters["line"] = line
}
if let side = comment.side {
parameters["side"] = side
}
if let startLine = comment.startLine {
parameters["start_line"] = startLine
}
if let startSide = comment.startSide {
parameters["start_side"] = startSide
}
return parameters
}
}
return parameters
}
}

var path: String {
switch self {
case let .postReview(_, owner, repository, pullRequestNumber, _, _, _, _):
return "repos/\(owner)/\(repository)/pulls/\(pullRequestNumber)/reviews"
}
}
}
Loading