Enable dyn dispatch by dyn Config objects #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is nice! Can you please add short/concise (one or two sentences) documentation for it to be discoverable - in README and lib.rs (for docs.rs) after byot documentation? |
|
OK, done |
64bit
reviewed
Jun 8, 2025
64bit
reviewed
Jun 8, 2025
64bit
reviewed
Jun 8, 2025
64bit
reviewed
Jun 8, 2025
64bit
reviewed
Jun 8, 2025
64bit
reviewed
Jun 8, 2025
64bit
reviewed
Jun 8, 2025
|
One of things that this feature must work for is dynamic dispatch same API call to multiple providers concurrently (via tokio::spawn ) - requiring I have suggested the corresponding test - please let me know if that looks good or if there are any concerns now that |
Co-authored-by: Himanshu Neema <[email protected]>
Co-authored-by: Himanshu Neema <[email protected]>
Co-authored-by: Himanshu Neema <[email protected]>
Co-authored-by: Himanshu Neema <[email protected]>
Co-authored-by: Himanshu Neema <[email protected]>
Co-authored-by: Himanshu Neema <[email protected]>
Co-authored-by: Himanshu Neema <[email protected]>
|
Looks good to me. Thanks! I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should supersede #125, solving #106. Different from #125, this is not a breaking change.