Verify r version matches during activate #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dpastoor, If you can review the edited content for activate.R in consts to make sure the R code makes sense (i.e. ordering of the messages makes sense) |
Keats
reviewed
Mar 3, 2025
src/main.rs
Outdated
| let context = CliContext::new(&cli.config_file)?; | ||
|
|
||
| if r_version { | ||
| println!("{}", context.config.r_version()); |
There was a problem hiding this comment.
We probably want to show context.config.r_version().original I think?
There was a problem hiding this comment.
That's what the display trait of Version does
Lines 90 to 94 in 28d2496
dpastoor
requested changes
Mar 3, 2025
r.version.check.mp4 |
Keats
force-pushed
the
activate_basic_info
branch
from
124be6c to
c1f87ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal
rv infowith--r-versionflag to allow for easy R version comparison